-
Notifications
You must be signed in to change notification settings - Fork 375
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
IcyInfo should be used in MediaMetadata #153
Comments
I think the
I think the same issue (developer-provided metadata overriding media-provided) probably affects your session demo example too. Can you take a look and see if you can also get this working in the main demo app as I've described? |
Hey @y20k. We need more information to resolve this issue but there hasn't been an update in 14 weekdays. I'm marking the issue as stale and if there are no new updates in the next 7 days I will close it automatically. If you have more information that will help us get to the bottom of this, just add a comment! |
Hi @icbaker When I use MediaItems that do not have a title set in their metadata, the player uses stream-provided metadata. It works flawless in my own app. The notification automatically displays IcyInfo from the stream. Thank you for the clarification and for helping me out! |
Glad it's working! |
Hi @icbaker as I wrote in October my app's notification displays IcyInfo metadata, once I do not set the title. ❤️ There is an unintended consequence of not setting the title though: The Always-On Display now reads: No Title The photos above are from a fork of the demo-session app (see y20k@2e722ac). I now wonder ... |
Thanks for the update - please can you file a new issue? You can link back to this issue for context, but it's helpful to keep the discussions separate. |
Okay. I created a new issue. |
Some radio streams publish Icecast metadata. ExoPlayer extracts Icecast metadata in the form of
IcyHeaders
andIcyInfo
.IcyHeaders
are used to populate thestation
andgenre
fields inMediaMetadata
. You can check that for example inonMediaMetadataChanged
(Player.Listener):station
andgenre
are being updated.IcyInfo
usually contains information like the currently playing song. It is being extracted properly. You can check that for example inonMetadata
(Player.Listener). There is also a function that can populateMediaMetadata
. I would correctly update thetitle
field. Problem: It seems like this function is never used, because thetitle
field is not updated inonMediaMetadataChanged
(Player.Listener).I tested this behavior in the Media Session Demo app. If you want to reproduce the behavior you would need run the forked app and start the radio station that I added to catalog.json and filter LogCat for "ICY issue" (1) (2) (3).
I think
IcyInfo
should be used inMediaMetadata
because it contains really interesting information about the currently playing media.The text was updated successfully, but these errors were encountered: