Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add RTP VP8 test #110

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

basantwanishraddha
Copy link
Contributor

Exoplayer RTP VP8 Reader had few issues.
Created a issue describing the same.

Fixed the reported issue in the PR and added RTP VP8 tests as well.

Copy link
Contributor

@claincly claincly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good overall, merging internally.

Set the fixed clock rate in VP8 Reader Test

Change-Id: I0bdedc803bb892d93fde2a027a01cb49a48597ef
rohitjoins added a commit that referenced this pull request Jul 13, 2022
Reset fragmentedSampleSizeBytes to LENGTH_UNSET.

Change-Id: Ie8a66702a7e26b5e240a7163dac6343531f1b49f
@basantwanishraddha
Copy link
Contributor Author

The merge commit 9d9bbe3, addresses the two review comments. We can skip these 2 commits.

rohitjoins added a commit that referenced this pull request Jul 15, 2022
PiperOrigin-RevId: 460513413
(cherry picked from commit 9d9bbe3)
@claincly
Copy link
Contributor

claincly commented Jul 18, 2022

Thanks for making the change. Could you create a new PR for the two recent commits, as the original PR is already merged into main?

@basantwanishraddha
Copy link
Contributor Author

The review comments addressed in the recent two commits are already resolved in commit 9d9bbe3 and merged on main. We can discard the recent two commits.

marcbaechinger pushed a commit that referenced this pull request Sep 30, 2022
PiperOrigin-RevId: 460513413
(cherry picked from commit c75b6a3)
marcbaechinger pushed a commit that referenced this pull request Sep 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants