Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Catch errors and OOM when decoding ID3 frames. #369

Merged
merged 3 commits into from
Jan 4, 2024
Merged

Catch errors and OOM when decoding ID3 frames. #369

merged 3 commits into from
Jan 4, 2024

Commits on Jan 3, 2024

  1. Catch errors and OOM when decoding ID3 frames. 

    Invalid frames have no impact on ExoPlayer ability to play the media and should not fail on errors.
Some tools can add 100Mb images in the tags that will trigger recoverable OOM with this fix.
    @Tolriq @icbaker
    Tolriq authored and icbaker committed Jan 3, 2024
    Configuration menu
    Copy the full SHA
    de772cf View commit details
    Browse the repository at this point in the history

  2. Format with google-java-format

    @icbaker
    icbaker committed Jan 3, 2024
    Configuration menu
    Copy the full SHA
    820278c View commit details
    Browse the repository at this point in the history

  3. Improve logging by including full stack trace, and add release note

    @icbaker
    icbaker committed Jan 3, 2024
    Configuration menu
    Copy the full SHA
    f935f59 View commit details
    Browse the repository at this point in the history