-
Notifications
You must be signed in to change notification settings - Fork 79
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cannot change language #145
Comments
Please see this page for instructions on how to change it back to English: https://developer.chrome.com/extensions/i18n#win-ui The Windows instructions on that page are outdated, you can find updated instructions for Windows here: https://support.google.com/chrome/answer/173424 (under the "Change the language of your Chrome browser (Windows & Chromebook only)" heading) |
Thanks for your very prompt response and sorry for opening an issue about this, I wasn't aware I still had Chrome set to a different language and assumed the issue being with your extension. |
No worries at all! All the best to you and your family over the holiday season. |
Hi, same problem here: Chrome browser set to Italian language and ScriptSafe 1.0.8.5 now also in Italian. However I was happy with ScriptSafe in English and Chrome in Italian. So in order to change ScriptSafe back to English the only chance I have is to change Chrome interface language, isn't it? Or is there the possibility to change the ScriptSafe language only? |
Same as m32po here, the UI design is completely broken in French. |
@m32po I looked for workarounds but unfortunately the Chrome extension API only allows me to get the UI locale and not set it. @trou thanks for the report, I am working on redesigning the ScriptSafe panel to better accommodate all locales and ensure the buttons are not cut off. I've received several reports of the Russian and German locales having issues where buttons in the panel are going beyond the width of the panel. |
I must confess I have the same problem as @trou. With ScriptSafe localized to Italian, some UI buttons break the layout. I attached a couple of screen snips. But it isn't a big issue for me now, I set Chrome to English as a workaround. |
@m32po thanks for the screenshots! Here's my solution to it that I'm currently working on - changing it from a two-column layout to one-column: Another benefit of this is that the Options, Refresh, and Close buttons are now easily accessible and all the domain control buttons match up. |
I'm always in favor of options: maybe add a radio button to display your extension in english no matter the actual locale of the browser, something like "use browser locale [ ] use english [x]"? |
@uxlapogi I am the same and would have loved to provide that option to users, but unfortunately there is no way to have ScriptSafe dynamically set the user's desired locale as the most I can do is just retrieve locale-related data and not for example set the locale to be "en", "it", etc: https://developer.chrome.com/extensions/i18n#methods Because of this, I've decided to redesign the panel to make better use of space in the panel, and have only included translations in the official Web Store release which have been reviewed by individuals fluent in each respective language. I will be posting the beta here within the next day or two. I believe I managed to fix the issue where the panel scrollbar sometimes won't scroll as well. |
v1.0.9.0 Beta has been posted for testing :) #153 |
@andryou Italian locale seems to be working fine now. The one column layout solution is better than two columns one, it is more consistent, now also the primary domain is aligned to the left with the others and it has the rating button as well. God job! |
@andryou I think you misunderstood what I proposed. I don't want you to set the locale of the browser, I want you to add an option to completely ignore it, so that there are essentially two locale: the browser and the extension locale. Ideally that would mean the four functions you linked are only there to propose the initial language like 'hey there, you are starting scriptsafe for the first time, I set the locale for this extension to the same one as your browser, do you want to change it to something else so you can view this extension in spanish on a french browser on a spanish windows?' Because usually what happens with this auto detect stuff on websites is 'Hey there, I see you have an english windows, an english browser, set your language preferences to english and explicitly requested to view this website in english but screw you! You are requesting this page from a german IP so here is an auto translated mess that will give your grandchildren cancer in their graves. Have a nice day!' I am using a couple of extensions that are only available in english. That doesn't mean they don't work when I live in Mongolia, it just means it's in english, because they are hardcoded in english. (They are my favorite actually, since we are already at 12 comments now and the whole thing would've never happened in the first place. *wink But I understand if someone wants to use their mother tongue.) |
@andryou I agree with @uxlapogi, the possibility to set ScriptSafe locale ignoring browser locale it could be useful. The one column layout is a very good improvement but doesn't answer what @uxlapogi asked with the issue #145 in the first place, that is "Cannot change language", more precisely "I cannot change the ScriptSafe language ignoring the browser one". I hope I understood correctlty what @uxlapogi asked, so I tweaked a little bit of HTML code and I took these two snips to get an idea of what could be a ScriptSafe Language option, based on what are the ScriptSafe locales available now: |
Thank you both for your thoughts and input! Over the next couple of weeks
I'll look into the possibility of creating a custom locale parsing system,
overriding the native Chrome chrome.i18n API. This would give me the
ability to allow users to change the language at any time, which the native
API does not.
My current priority is wrapping up beta testing soon to get the improved
panel (and other updates) to all users as soon as possible so that the
panel is usable in all languages.
|
Looks like it was simpler than I thought! The next version will include the ability to change the language, where the change will be immediate. I will continue looking through submitted issues to see what I can fix, then have a public beta testing period for v1.0.9.1. If anyone is curious, you can download a zip of this repo and load it into Chrome. Relevant commit: 3e38d40 |
v1.0.9.1 Beta is now available for testing: #166 |
v1.0.9.1 has been published in the Chrome and Opera stores which addresses this issue. Thanks again for your report and testing! |
The latest update changed my Scriptsafe language and I cannot change it back to english.
The text was updated successfully, but these errors were encountered: