Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Blur amount is dependent on resolution at launch #4

Open
omgitsraven opened this issue Jun 21, 2018 · 6 comments
Open

Blur amount is dependent on resolution at launch #4

omgitsraven opened this issue Jun 21, 2018 · 6 comments
Assignees
Labels
bug Something isn't working

Comments

@omgitsraven
Copy link
Contributor

I just tried making a Windows build of a game that uses this effect, and the blur worked, but was distinctly less blurred than it appeared in the editor:

sbs

blur

This happens in Unity 2018.1.2f1 and in Unity 2018.2.0b9. I'm running Windows 10.

@andydbc
Copy link
Owner

andydbc commented Jun 21, 2018

Could it be related to your Quality Settings ?

@omgitsraven
Copy link
Contributor Author

OK, I've just confirmed that it doesn't have to do with Quality Settings, but in the process I accidentally found what it DOES have to do with -- the amount of blur in the editor seems to be relative to whatever the resolution of the "game" pane was at the START of playback. When I was making my test case, I did "build and run", then went back to the editor, hit play, popped out the "game" tab, and THEN resized it to fit with the running game. At that point, if I turn play mode off and on again, THEN it matches.

Hopefully that's a good diagnostic as to how to fix this, because unfortunately it isn't much of a workaround for me, because where I'm actually using this is in VR... I'm pretty sure I'm rendering at the same VR resolution in the editor as in the build, but the blur is distinctly different regardless, which I guess means to work around this I'd have to resize my editor window to fit whatever buffers the standalone VR build is using, but I'm not sure what that would be?

Also, I just confirmed that the same amount of blur looks very different at different resolutions (even when working around the bug), here's the same scene but at half the size (then scaled up 2x for comparison)
scale

@andydbc andydbc self-assigned this Jun 21, 2018
@andydbc andydbc added the bug Something isn't working label Jun 21, 2018
@omgitsraven omgitsraven changed the title Blur amount is very different in builds vs editor Blur amount is dependent on resolution at launch Jun 21, 2018
@omgitsraven
Copy link
Contributor Author

OK so I just realised this has turned into a discussion of two different issues, but I have a workaround for one of them at least.

I can do a pull request to fix the fact that changing window size while it's running distorts the blur. I haven't yet figured out what to change to make the blur look similar at different resolutions. Should I do the PR for the first issue or wait until I've addressed both?

@andydbc
Copy link
Owner

andydbc commented Jun 21, 2018

You're welcome to do one PR per issue :)

@omgitsraven
Copy link
Contributor Author

OK, the "it looks weird if you change the window size while it's running" bug is fixed here: #5

@omgitsraven
Copy link
Contributor Author

OK, I think I've now got the original issue of the thread also fixed in #6

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants