Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Able to hit 'unknown command 'EVALSHA'' when using a lualock on redis 2.2 #550

Closed
harlowja opened this issue Oct 28, 2014 · 2 comments
Closed
Labels

Comments

@harlowja
Copy link
Contributor

It appears that redis 2.2 (when used) will correctly pass the lualock code (which it doesn't seem like it should) and then it will blowup with errors such as 'unknown command 'EVALSHA''.

An example log we hit that shows this (on ubuntu precise which has redis 2.2):

http://logs.openstack.org/42/131442/1/check/gate-tooz-python33/e4560c5/console.html

openstack-gerrit pushed a commit to openstack/tooz that referenced this issue Nov 3, 2014
Avoid using lua locks

The default redis library will try to be smart about using
or not using lua based locks, it seems to not correctly predict
this correctly and then fails with errors such as:

''unknown command 'EVALSHA''

Upstream issue filed:

redis/redis-py#550

The 'traditional' locks require PEXPIRE used by the redis-py
library which requires redis 2.6+ to actually work. So when
we are using a server version that is not new enough
we should conditionally raise a not implemented error to
avoid it later failing (which it will).

This also fixes a bunch of encoding issues that the enabling
of the py33 system now exposed (damn encodings...)

Change-Id: Ied6045276c9a1398db710a68aa75fe92aac9b4bb
@rouge8
Copy link

rouge8 commented Apr 10, 2017

Likely broken by this commit: 0340f1b

@github-actions
Copy link
Contributor

This issue is marked stale. It will be closed in 30 days if it is not updated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants