New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

consider calling redis.SET to replace redis.SETNX and redis.PEXPIRE in lock.py #793

Closed

andytzeng opened this issue Oct 20, 2016 · 1 comment

andytzeng commented Oct 20, 2016

Follow the suggestion from Redis SET, SET command support EX, PX, NX, XX options. Based on the note:

Note: Since the SET command options can replace SETNX, SETEX, PSETEX, it is possible that in future versions of Redis these three commands will be deprecated and finally removed.

It is better to replace redis.SETNX and redis.PEXPIRE with redis.SET in lock.py

andymccurdy closed this as completed in

255f010

Contributor

andymccurdy commented Nov 15, 2018

This was fixed at some point in the past. Sorry for not updating this issue sooner.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment