code-style improvements, setup for better date filter handling

andyperlitch · Sep 6, 2013 · b366354 · b366354
1 parent 139b905
commit b366354
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 8 deletions.
diff --git a/index.js b/index.js
@@ -33,7 +33,7 @@ var ConfigModel = Backbone.Model.extend({
             return "Offset must be greater than 0";
         }
         if (attrs.max_rows < 1) {
-            return "max_rows must atleast 1";
+            return "max_rows must at least be 1";
         }
     },
     getVisibleRows: function() {
@@ -260,8 +260,6 @@ var Tabled = BaseView.extend({
 
     },
 
-
-
     grabTableResizer: function(evt){
         evt.preventDefault();
         evt.stopPropagation();
@@ -293,7 +291,7 @@ var Tabled = BaseView.extend({
             var abChangeY = Math.abs(changeY);
             if ( abChangeY > row_height) {
                 abChangeY = Math.floor(abChangeY/row_height) * (changeY > 0 ? 1 : -1);
-                self.config.set({'max_rows':initMax + abChangeY}, {validate:true});
+                self.config.set({'max_rows':initMax + abChangeY}, { validate: true });
             }
         } 
         var cleanup_resize = function(evt) {

diff --git a/lib/Filters.js b/lib/Filters.js
@@ -89,17 +89,19 @@ exports.date = function(term, value) {
         var lowerbound = now - parseDateFilter(against_2);
         return value >= lowerbound;
     }
-    if ( first_two == ">=" ) {
+    else if ( first_two == ">=" ) {
         var upperbound = now - parseDateFilter(against_2);
         return value <= upperbound;
     }
-    if ( first_char == "<" ) {
+    else if ( first_char == "<" ) {
         var lowerbound = now - parseDateFilter(against_1);
         return value > lowerbound;
     }
-    if ( first_char == ">" ) {
+    else if ( first_char == ">" ) {
         var upperbound = now - parseDateFilter(against_1);
         return value < upperbound;
+    } else {
+        // no comparative signs found
+        return false;
     }
-    return false ;
 }