Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Testing / CI #4

Closed
andywer opened this issue Dec 28, 2016 · 5 comments
Closed

Testing / CI #4

andywer opened this issue Dec 28, 2016 · 5 comments

Comments

@andywer
Copy link
Owner

andywer commented Dec 28, 2016

There must be at least some integration test showing that the whole thing works and works for different node versions.

Correlates with #3 and will be successor of a proposed change in #1.

@btmills
Copy link

btmills commented Dec 28, 2016

Since I've already attempted setting this up in Travis, I'll share what I found to give you a head start:

Compiling nan, a transitive dependency via memwatch-next in a Travis container requires a newer compiler than what the environment supplies by default. btmills/queue@0fddbf9 configures Travis to install and use g++-4.8, which allows leakage to be installed. With that change, that PR is now passing in Node v6 and v7, and the failures in v4 and v5 are unrelated and will be fixed once #3 is closed.

Once this repository is set up and working in Travis, it would be helpful to document Travis setup instructions (whether the config I linked above or something better) in the readme. I was going to send a PR for that once I had a fully working setup (so pending #3), but since you're looking at setting up Travis for this repository, I left a note here in the meantime!

@andywer
Copy link
Owner Author

andywer commented Dec 28, 2016

That really is a head start 😉 Thanks a lot!

But do you think people using the lib care about the travis config? Don't know if documenting it in the README really serves a purpose.

@btmills
Copy link

btmills commented Dec 28, 2016

Anyone using leakage who wants to run a leak test in Travis will need to make those changes to .travis.yml. Without them, leakage -> memwatch-next -> nan will fail to install, causing the whole build to go 💥

Edit: So it's not just this repository that needs the modified config - it's any repository that wants to use leakage as part of the Travis tests.

@andywer
Copy link
Owner Author

andywer commented Dec 28, 2016

Of course! 🙈

I am working on #4 right now and will document it properly. I would appreciate you reviewing my PR once it is done :)

@mastilver
Copy link

Didn't realize (Didn't really check to be honest :$) you were a already working on that
I've submitted a PR #5 , feel free to close it if you already have something working

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants