-
Notifications
You must be signed in to change notification settings - Fork 52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Testing / CI #4
Comments
Since I've already attempted setting this up in Travis, I'll share what I found to give you a head start: Compiling Once this repository is set up and working in Travis, it would be helpful to document Travis setup instructions (whether the config I linked above or something better) in the readme. I was going to send a PR for that once I had a fully working setup (so pending #3), but since you're looking at setting up Travis for this repository, I left a note here in the meantime! |
That really is a head start 😉 Thanks a lot! But do you think people using the lib care about the travis config? Don't know if documenting it in the README really serves a purpose. |
Anyone using Edit: So it's not just this repository that needs the modified config - it's any repository that wants to use |
Of course! 🙈 I am working on #4 right now and will document it properly. I would appreciate you reviewing my PR once it is done :) |
Didn't realize (Didn't really check to be honest :$) you were a already working on that |
There must be at least some integration test showing that the whole thing works and works for different node versions.
Correlates with #3 and will be successor of a proposed change in #1.
The text was updated successfully, but these errors were encountered: