Move generic client APIs into pkg/apis/ #86
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This makes much more visible which APIs are supported by the generic client, makes it easier to have generic client supporting APIs not sharing any code with existing old clients and is a place where other big projects place their API definitions. Also adds code generator comments to the objects and fixes lbaasv1.Frontend (which wasn't an object anymore - code gen test catched it).
LittleFox94
force-pushed
the
generic-client-apis-pkg
branch
from
ca46cdf
to
32ca322
Compare
Codecov Report
@@ Coverage Diff @@
## main #86 +/- ##
==========================================
- Coverage 55.80% 55.61% -0.20%
==========================================
Files 89 93 +4
Lines 4012 4051 +39
==========================================
+ Hits 2239 2253 +14
- Misses 1409 1433 +24
- Partials 364 365 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
kstiehl
approved these changes
Nov 29, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This makes much more visible which APIs are supported by the generic client, makes it easier to have generic client supporting APIs not sharing any code with existing old clients and is a place where other big projects place their API definitions.
Release Note
Release note for CHANGELOG:
References
Community Note