Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix LBaaS VIP discovery fallback #151

Merged
merged 1 commit into from
Jan 4, 2023
Merged

Fix LBaaS VIP discovery fallback #151

merged 1 commit into from
Jan 4, 2023

Conversation

marioreggiori
Copy link
Contributor

If no resource with auto-discovery tag was found, the engine returns a 422 error. This error prevents falling back to the legacy discovery logic. This PR prevents error propagation in new auto-discovery logic due to 422 responses.

Checklist

References

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request

@codeclimate
Copy link

codeclimate bot commented Jan 3, 2023 •
edited
Loading

Code Climate has analyzed commit 2b33f3f and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 53.2% (0.3% change).

View more on Code Climate.

@marioreggiori marioreggiori force-pushed the fix-lbaas-vip-fallback-discovery branch from b8a5f0b to 0030a9f Compare January 4, 2023 07:07
@marioreggiori marioreggiori force-pushed the fix-lbaas-vip-fallback-discovery branch from 0030a9f to 2b33f3f Compare January 4, 2023 09:21
speijnik
speijnik approved these changes Jan 4, 2023
View reviewed changes
Copy link
Member

@speijnik speijnik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me 👍

@marioreggiori marioreggiori merged commit fdcfca5 into main Jan 4, 2023
@marioreggiori marioreggiori deleted the fix-lbaas-vip-fallback-discovery branch January 4, 2023 09:36
@LittleFox94 LittleFox94 added bug Something isn't working patch labels Apr 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@speijnik speijnik speijnik approved these changes

@LittleFox94 LittleFox94 Awaiting requested review from LittleFox94

Assignees
No one assigned
Labels
bug Something isn't working patch
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@marioreggiori @speijnik @LittleFox94