Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump k8s.io/cloud-provider from 0.26.3 to 0.27.0 #189

Merged
merged 3 commits into from
Apr 14, 2023

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Apr 12, 2023

Bumps k8s.io/cloud-provider from 0.26.3 to 0.27.0.

Commits
  • 9379a11 Update dependencies to v0.27.0 tag
  • 82a6856 Merge remote-tracking branch 'origin/master' into release-1.27
  • 4e01cb4 Export WebhookHandler struct because some CCMs use Run directly
  • f5f43a4 Merge remote-tracking branch 'origin/master' into release-1.27
  • 9f3bbd5 .*: update vendor dir and cleanup
  • fe18149 Add CloudDualStackNodeIPs feature gate(s)
  • 47e45ed Update GetNodeAddressesFromNodeIP and ParseNodeIPAnnotation for cloud dual-stack
  • b599f38 Update GetNodeAddressesFromNodeIP to take the unparsed annotation
  • f48fbdf Split up PreferNodeIP into legacy and non-legacy versions
  • 0555c1a Move kubelet --node-ip parsing to component-helpers
  • Additional commits viewable in compare view

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

@dependabot dependabot bot added dependencies Pull requests that update a dependency file minor indicates that this change introduces a change that increments the minor version labels Apr 12, 2023
@eiabea eiabea self-requested a review April 13, 2023 10:10
Bumps [k8s.io/cloud-provider](https://github.com/kubernetes/cloud-provider) from 0.26.3 to 0.27.0.
- [Release notes](https://github.com/kubernetes/cloud-provider/releases)
- [Commits](kubernetes/cloud-provider@v0.26.3...v0.27.0)

---
updated-dependencies:
- dependency-name: k8s.io/cloud-provider
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
@LittleFox94 LittleFox94 force-pushed the dependabot/go_modules/k8s.io/cloud-provider-0.27.0 branch from 592ef0a to f739cde Compare April 13, 2023 10:17
@codeclimate
Copy link

codeclimate bot commented Apr 13, 2023

Code Climate has analyzed commit 9ab61f0 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 55.8% (0.0% change).

View more on Code Climate.

@eiabea eiabea requested review from LittleFox94 and removed request for eiabea April 13, 2023 12:10
Fix deprecation issues
@eiabea eiabea force-pushed the dependabot/go_modules/k8s.io/cloud-provider-0.27.0 branch 2 times, most recently from 9b1efe6 to 839cc18 Compare April 13, 2023 12:16
@LittleFox94
Copy link
Collaborator

LittleFox94 commented Apr 13, 2023

Please add an entry in CHANGELOG.md for upgraded k8s dependencies and Go version

It's a bit sad we can't make dependabot add the changelog entry itself ... maybe we should add something to our CI to sync the draft release (which is automatically created by release-drafter) with the CHANGELOG.md 🤔

@LittleFox94 LittleFox94 added patch and removed minor indicates that this change introduces a change that increments the minor version labels Apr 13, 2023
@LittleFox94
Copy link
Collaborator

I also removed the "minor" label and added "patch" instead - we have a bad double-use for those labels :/
dependabot sets them based on the version jump, while release-drafter uses them to calculate the version number of the next release

@eiabea eiabea force-pushed the dependabot/go_modules/k8s.io/cloud-provider-0.27.0 branch from 839cc18 to a29f889 Compare April 13, 2023 12:36
@eiabea
Copy link
Contributor

eiabea commented Apr 13, 2023

I am quite new to dependabot, but maybe we craft a ticket for this changelog proposal for the next sprint?

CHANGELOG.md Outdated Show resolved Hide resolved
@LittleFox94
Copy link
Collaborator

I am quite new to dependabot, but maybe we craft a ticket for this changelog proposal for the next sprint?

dependabot is completely out of our control, being a github service just enable with very few config options - we would have to craft something fresh for that. But we also have a quite diverse build system landscape ... here we have release-drafter, over at go-anxcloud or our terraform provider we don't. Before we craft something, we should probably try to find which way we wanna have it and use that on all projects, or at least decide on one way, craft a solution for the changelog problem and then, if that works out, use that way on every project.

TL;DR: nothing to quickly define to do next sprint

@eiabea eiabea force-pushed the dependabot/go_modules/k8s.io/cloud-provider-0.27.0 branch from a29f889 to 33b14ef Compare April 13, 2023 15:12
Update changelog
@eiabea eiabea force-pushed the dependabot/go_modules/k8s.io/cloud-provider-0.27.0 branch from 33b14ef to 9ab61f0 Compare April 13, 2023 15:14
@eiabea eiabea merged commit 69e990a into main Apr 14, 2023
@dependabot dependabot bot deleted the dependabot/go_modules/k8s.io/cloud-provider-0.27.0 branch April 14, 2023 07:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file patch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants