Slays/brands with birth_percent_damage add hidden extra damage

[tomm]

Looks like this has been the case since commit 40caf65

o_melee_damage() adds a flat +dam for slays, which is 10*slay multipler - 10. Ie a brand with 2.5x multiplier adds a flat 15 damage to the attack.

o_obj_known_damage() doesn't take this flat brand/slay +dam into account.

I don't know what the fix is, since I don't know which function is doing what was actually intended. The flat +dam doesn't seem in keeping with the general oangband damage calculation scheme, though...

[NickMcConnell]

IIRC the actual damage is correct

[backwardsEric]

It does look like o_obj_known_damage() does include the additive term (see lines 1046, 1077, 1082, and 1113 of obj-info.c in the current master branch). The additive term is in OAngband: line 839 of https://github.com/oangband/Oangband/blob/master/src/attack.c .

[backwardsEric]

Though from what I see, the scaling of the added term in the object information calculations is not correct thus #5703 .

[NickMcConnell]

So is this done?

[backwardsEric]

I believe it is. What I see is that the actual calculations and those for the object information agree, and that they match what's in OAngband. tomm may want to look at it and see what he thinks.