-
Notifications
You must be signed in to change notification settings - Fork 77
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Need to upgrade Braintree JavaScript v2 SDK to JavaScript v3 SDK #1101
Comments
@kcppdevelopers I had Braintree configured already on woo.angelleye.com. I have now updated the site with the current dev branch here, and when I try to load the checkout page it's giving me a generic error...
When I look at the Braintree log I see this:
So somehow this update causes our previously entered credentials to break..?? |
@kcppdevelopers Another thing I notice while looking at this is that the timestamp on the log file is incorreect. The stamp in the actual log (as shown above) is correct with 10:49:42. However, the timestamp shown when the log file was actually created is incorrect... It shows it was created at 3:49 PM..?? I did delete the log file and run another test to make sure that wasn't an old timestamp, and again, it says 3:49 pm when the actual time here is 10:49 am. |
@kcppdevelopers I have now re-entered my API credentials into the Braintree settings, and now it's working fine. So yeah, something about this update caused the previously entered values to become obsolete..?? This is not good because anybody using Braintree that updates would break until they re-enter their credentials. |
@kcppdevelopers After updating my credentials I'm able to load the checkout page again, but now I'm discovering another issue. I left the checkout forms completely blank, and I click Place Order, but "nothing" happens. It does not load any sort of spinner on the page itself or even in the browser tab. If I scroll up I do see a red highlight on the State field, as if it's required, but it's not giving me any actual messages about validation or required fields, and it didn't scroll back up to make this clear when I clicked the Place Order button. This is not a good user experience. When I switch back to PayFlow and click Place Order then all of the fields highlight red and it sends me back to the top with a bunch of validation error messages as expected. This needs to happen with Braintree as well. |
@kcppdevelopers Another issue I'm having here. I went ahead and started filling out all of the checkout fields to see if I could get through checkout that way. When I enter my zip code I get a spinner while it updates shipping options, but then it popped up this error: Actually, what's interesting here is that this happened when I updated the Billing Zip Code, which wouldn't be used for shipping anyway. That should be based on the Shipping zip code. |
@kcppdevelopers It seems the validation issues are only happening with the drop-in UI. |
@angelleye In the Braintree there are two SDK version for drop-in UI 1) V2 and 2) V3 Why upgrade to v3: No dependency on form submission: Previous versions of the SDK required a form submission for tokenization. Now we're giving you control of tokenization through a simple API call. Hosted Fields formatting: This release introduces input formatting in Hosted Fields, creating a UX-friendly and PCI-compliant experience. Smaller file size: Our new modular component structure means you can selectively include payment methods to fit your needs. Improved error messaging: One of our main goals in this version of the SDK is to make error messaging much more transparent, giving you a clearer picture of what’s happening in your checkout flows. And more... |
@iMansoorAliKhan I am done with above issue, could you please help to re test this issue? |
@kcppdevelopers @iMansoorAliKhan This is still not working for me. I'm having the same exact problem I reported 2 days ago where the validation is not triggering at all on the checkout page. Also, I cannot get PayPal to work at all... I get that before I'm even seeing any login or anything, so it has nothing to do with Billing Agreement or duplicate ID or anything like that. I can't even load the login. |
Our log file here is not correct either. Not sure what changed, but now all I see is this in my log file...
|
@angelleye I have placed some orders using PayPal Braintree but yeah 1 time 1 Saw this error you have reported. |
@angelleye regarding validation I have applied few changes here and now it's working |
@kcppdevelopers the validation thing is not working just like other gateways, its not running loader just highlighting few fields, not all and button becomes irresponsive. |
@iMansoorAliKhan it's not our plugin issue, it is DIVI theme CSS issue. |
@iMansoorAliKhan I have disable our PayPal for Woo plugin and only enable case on delivery and it is still display same so it is not our plugin issue. |
@kcppdevelopers I'm a little confused here. The other gateways work just fine with Divi. Why would this one be any different? |
I agree with @angelleye if this is Divi issue then how come for Creditcard Rest it works fine, or incase of an other gateways from our plugin? |
@iMansoorAliKhan @angelleye I said I have disable our plugin and only enable "Cash on delivery" Payment method it from by default woo and still state/country filed highlight. so it is not our plugin issue. |
@kcppdevelopers Then what did we do in our other gateways that makes it work better? |
@angelleye After installing the most recent dev branch just today, I can confirm that the validation in-case of BT is working back again, It look like some old code was there which was not updating, |
Not sure what caused that trouble .... |
@iMansoorAliKhan So does that mean this is ready for my review? |
@angelleye Yeah, I have tried many things , ran many test so far its running smooth for me. |
I just pulled the dev branch and uploaded everything fresh to woo.angelleye.com. I am running in Chrome Incognito, and I still do not see proper validation happening on this Braintree gateway. I don't understand why this is becoming such a complicated thing for us to all get on the same page with. Here is another video explaining what I'm seeing vs. what I expect to see: http://fiber.angelleye.com/temp/paypal-for-woo-braintree-validation.mp4 |
@angelleye This is how I have tested this https://www.useloom.com/share/f88972d2cb1344e18bcd7237217582be , and not sure if this is related to new JS or what..... |
@iMansoorAliKhan Okay, so the difference is that you're filling in the Braintree iFrame form, which then does seem to trigger the regular WC validation when submitted. @kcppdevelopers I see you made a new commit here. Does that mean you see what I've been trying to say now and are making necessary adjustments? |
@angelleye I found when user not filling in the Braintree iFrame form and press order button on that time validation not working so I have making necessary adjustments for that. |
@kcppdevelopers in case of normal braintree form, the validation works fine but only show error for card expiration date? Is that the expected behavior?? |
@iMansoorAliKhan Yes it is expected behavior. |
@kcppdevelopers the validation still needs to be fixed. Please see this, and the load time for drop-in UI??? can we make it quicker ? |
No description provided.
The text was updated successfully, but these errors were encountered: