-
Notifications
You must be signed in to change notification settings - Fork 77
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Minor Tweaks for 1.4.9 #1122
Comments
Regarding Smart button vertical : Large CSS it's depend on themes CSS I think medium and small are best suitable for DIVI themes. if I add some CSS then it will conflict with other theme so it would be great to remain as it. Regarding notice: I have resolved issue and push to dev branch. Regarding JS console error: I have already resolved it in previous issue. |
@kcppdevelopers what I saw is that you have given a fixed width of 250px to the container, so in case of responsive, medium and large the width is same, which is why the large button tend to align to the right rather than fitting in the middle. So may be you can find some better option / css for large buttons? without disturbing the oother themes css. I have tested with 3 top themes, divi, beTheme, Avada. |
Using Braintree PayPal option getting follow error, in-context is working with Braintree PayPal Error: PayPal Powered by Braintree was unable to complete the transaction. Please try again later or use another means of payment. Reason: PayPal Blocking Duplicate Order IDs |
Another thing which I;m seeing since yesterday is that, when , on my sandbox site, I click on shop which loads shop page , I click on a product and that open product detail page, there I dont see smart buttons, but then I do CTRL + SHIFT + R then it loads the smart buttons. |
@iMansoorAliKhan I have on your website and it's seem working for me. may be caching issue. |
this is strange though,. you switched theme to Divi then switched back to storefront and it started to show again. @angelleye , This issue seems to be final now. |
The character encoding of the HTML document was not declared. The document will render with garbled text in some browser configurations if the document contains characters from outside the US-ASCII range. The character encoding of the page must be declared in the document or in the transfer protocol. notice being reported either n backend and now on front-end, with an internal server error and this notice in console in backend I saw this when I was refunding a authorization order ( using PayFlow ) |
@iMansoorAliKhan I have discus all above thing on slack and confirm that issue is ready to reviews. |
@angelleye This issue can be closed now. |
@iMansoorAliKhan , @kcppdevelopers I see some Braintree validation adjustments in this issue, which are related to #1101, but I still cannot see proper validation, so I cannot close either of these issues. |
@angelleye you are seeing that issue on woo? But yesterday I have tested it on woo and validation worked for me on my sandbox and woo as well. |
which validation you are referring to... |
@iMansoorAliKhan Yes, this is happening on woo.angelleye.com. Take a look in #1101. My last comment I left a video link showing what's happening. |
@angelleye OK |
Smart button vertical : Large
http://prntscr.com/jg07px
On save , notice duplications, not this even the billing agrement.
bRAINTREE DROP-PIN ISSUE.
The text was updated successfully, but these errors were encountered: