Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor Tweaks for 1.4.9 #1122

Closed
iMansoorAliKhan opened this issue May 10, 2018 · 20 comments
Closed

Minor Tweaks for 1.4.9 #1122

iMansoorAliKhan opened this issue May 10, 2018 · 20 comments
Assignees
Milestone

Comments

@iMansoorAliKhan
Copy link

Smart button vertical : Large
http://prntscr.com/jg07px

On save , notice duplications, not this even the billing agrement.
image

bRAINTREE DROP-PIN ISSUE.

image

@kcppdevelopers
Copy link
Contributor

@iMansoorAliKhan

Regarding Smart button vertical : Large CSS it's depend on themes CSS I think medium and small are best suitable for DIVI themes. if I add some CSS then it will conflict with other theme so it would be great to remain as it.

Regarding notice: I have resolved issue and push to dev branch.

Regarding JS console error: I have already resolved it in previous issue.

@iMansoorAliKhan
Copy link
Author

@kcppdevelopers what I saw is that you have given a fixed width of 250px to the container, so in case of responsive, medium and large the width is same, which is why the large button tend to align to the right rather than fitting in the middle.

So may be you can find some better option / css for large buttons? without disturbing the oother themes css. I have tested with 3 top themes, divi, beTheme, Avada.

image
image

@iMansoorAliKhan
Copy link
Author

Braintree taking more that 16 digits card?

image

Also this one, when I hit pay button follow error reported in the console.

image

@iMansoorAliKhan
Copy link
Author

In avada at product level its showing like this, verticla large button
image

@iMansoorAliKhan
Copy link
Author

Using Braintree PayPal option getting follow error, in-context is working with Braintree PayPal

Error: PayPal Powered by Braintree was unable to complete the transaction. Please try again later or use another means of payment. Reason: PayPal Blocking Duplicate Order IDs

@iMansoorAliKhan
Copy link
Author

Even After applying the last comitt I'm seeing this error
image

@iMansoorAliKhan
Copy link
Author

Another thing which I;m seeing since yesterday is that, when , on my sandbox site, I click on shop which loads shop page , I click on a product and that open product detail page, there I dont see smart buttons, but then I do CTRL + SHIFT + R then it loads the smart buttons.
I have tested this on firefox and chrome and only to reproduce is to be login to as admin

image

@kcppdevelopers
Copy link
Contributor

@iMansoorAliKhan I have on your website and it's seem working for me. may be caching issue.

@iMansoorAliKhan
Copy link
Author

this is strange though,. you switched theme to Divi then switched back to storefront and it started to show again. @angelleye , This issue seems to be final now.
Please check and close it

@iMansoorAliKhan
Copy link
Author

on woo.angelleye.com with newest dev branch installed, when I click on prooced to checkout, this notice comes in console/.
image

is this something we need to look? this was not coming before...

@iMansoorAliKhan
Copy link
Author

iMansoorAliKhan commented May 15, 2018

this place holder button ( in case of BT ) becomes irresponsive for some unknown reason, it works and then all in a sudden it wont.
image

@iMansoorAliKhan
Copy link
Author

The character encoding of the HTML document was not declared. The document will render with garbled text in some browser configurations if the document contains characters from outside the US-ASCII range. The character encoding of the page must be declared in the document or in the transfer protocol.

notice being reported either n backend and now on front-end, with an internal server error and this notice in console

in backend I saw this when I was refunding a authorization order ( using PayFlow )

@iMansoorAliKhan
Copy link
Author

image

@kcppdevelopers
Copy link
Contributor

@iMansoorAliKhan I have discus all above thing on slack and confirm that issue is ready to reviews.

@iMansoorAliKhan
Copy link
Author

@angelleye This issue can be closed now.

@angelleye
Copy link
Collaborator

@iMansoorAliKhan , @kcppdevelopers I see some Braintree validation adjustments in this issue, which are related to #1101, but I still cannot see proper validation, so I cannot close either of these issues.

@iMansoorAliKhan
Copy link
Author

@angelleye you are seeing that issue on woo? But yesterday I have tested it on woo and validation worked for me on my sandbox and woo as well.

@iMansoorAliKhan
Copy link
Author

which validation you are referring to...

@angelleye
Copy link
Collaborator

@iMansoorAliKhan Yes, this is happening on woo.angelleye.com. Take a look in #1101. My last comment I left a video link showing what's happening.

@iMansoorAliKhan
Copy link
Author

@angelleye OK

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants