Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PayPal Plus - Enable / Disable Bug #368

Closed
angelleye opened this issue Dec 20, 2015 · 2 comments
Closed

PayPal Plus - Enable / Disable Bug #368

angelleye opened this issue Dec 20, 2015 · 2 comments
Assignees
Labels
Milestone

Comments

@angelleye
Copy link
Collaborator

We have it setup so that if the WooCommerce currency is not set to a compatible value, then when you try to load the PayPal Plus settings panel it gives you a message that you can't use it because you aren't using the proper currency.

However, if we have EUR set, for example, and then we enable PayPal Plus...but then we go and change the currency to USD...PayPal Plus remains active and still overrides the payment gateways on the WooCommerce checkout page.

At that point I have to change the currency back to EUR so that I can load the PayPal Plus settings to disable it, and then change my currency back again.

We need to handle this somehow. Maybe automatically disable PayPal Plus if it is enabled and the currency is adjusted..?? Of course, we should display a notification that this will happen and let them say OK or Cancel before submitting the currency adjustment.

@kcppdevelopers
Copy link
Contributor

I have applied above changed expect display Java script OK or Cancel pop when WooCommerce currency is not supported to PayPal Plus. I have display admin notice instead of a Java script popup.

@angelleye
Copy link
Collaborator Author

I see this...

__( 'Gateway Disabled: PayPal Plus does not support your store currency (Supports: EUR, CAD).', 'woocommerce-gateway-paypal-pro')

Shouldn't that second parameter be 'woocommerce-gateway-paypal-plus' instead?

kcppdevelopers added a commit that referenced this issue Dec 23, 2015
@angelleye angelleye modified the milestones: 1.2, 1.1.7.6 Dec 26, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant