Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add "Custom Class" field for the Buttons/Links #644

Closed
tejasm-itpath opened this issue Mar 10, 2017 · 2 comments
Closed

Add "Custom Class" field for the Buttons/Links #644

tejasm-itpath opened this issue Mar 10, 2017 · 2 comments
Assignees
Milestone

Comments

@tejasm-itpath
Copy link

Right now I am facing problem with Button styles.
I look into the code and found that there are Inline CSS in the A tag and Img tags
Here is the File I found inline css
/wp-content/plugins/paypal-for-woocommerce/classes/wc-gateway-paypal-express-angelleye.php
It may be in other files also.

Because of the inline css , custom css is not working without adding !important .

If we remove all the inline css , and give user to add just Classes according to the theme they used then it will be very easy to use this images/links in every themes.
they can easily move and place the img/links also it will match with themes.
For every Button we can add Custom CSS input field where user add class name of particular theme and no need to worry about css work.

@angelleye angelleye added this to the 1.4.0 milestone Mar 10, 2017
@angelleye
Copy link
Collaborator

@kcppdevelopers Thoughts on this?

@kcppdevelopers
Copy link
Contributor

Yes, it would be great to have class attribute instead of inline CSS. I will change it soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants