get_state_code() should return state code instead of state name #1066
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the commit, we will review and merge that into next release. |
kcppdevelopers
added a commit
that referenced
this pull request
May 2, 2018
angelleye
pushed a commit
that referenced
this pull request
May 9, 2018
|
We have merged this and it will be included in our 1.4.9 update that we'll release this week. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I encountered this problem when I realize PayPal returns
Qldfor Queensland, Australia. While in WooCommerce, the valid state code isQLD, get_state_code('AU', 'Qld') will return 'Qld'.Also, I notice get_state_code() should return the code instead of the name, even for non-US countries.