Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

make Minicart by default disable, PFW-516 #1386

Merged
merged 2 commits into from
Nov 5, 2019
Merged

make Minicart by default disable, PFW-516 #1386

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
784180f
make Minicart by default disable, PFW-516
kcppdevelopers Oct 31, 2019
72310cd
make Minicart by default disable, PFW-516
kcppdevelopers Nov 1, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion angelleye-includes/express-checkout/class-wc-gateway-paypal-express-helper-angelleye.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,7 +60,7 @@ public function __construct() {
$this->show_on_checkout = !empty($this->setting['show_on_checkout']) ? $this->setting['show_on_checkout'] : 'top';
$this->button_position = !empty($this->setting['button_position']) ? $this->setting['button_position'] : 'bottom';
$this->show_on_cart = !empty($this->setting['show_on_cart']) ? $this->setting['show_on_cart'] : 'yes';
$this->show_on_minicart = !empty($this->setting['show_on_minicart']) ? $this->setting['show_on_minicart'] : 'yes';
$this->show_on_minicart = !empty($this->setting['show_on_minicart']) ? $this->setting['show_on_minicart'] : 'no';
$this->prevent_to_add_additional_item_value = !empty($this->setting['prevent_to_add_additional_item']) ? $this->setting['prevent_to_add_additional_item'] : 'no';
$this->prevent_to_add_additional_item = 'yes' === $this->prevent_to_add_additional_item_value;
$this->testmode_value = !empty($this->setting['testmode']) ? $this->setting['testmode'] : 'yes';
Expand Down
5 changes: 3 additions & 2 deletions classes/wc-gateway-paypal-express-angelleye.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -126,7 +126,7 @@ public function __construct() {
$this->fraud_management_filters = $this->get_option('fraud_management_filters', 'place_order_on_hold_for_further_review');
$this->invoice_id_prefix = $this->get_option('invoice_id_prefix', '');
$this->paypal_marketing_solutions_cid_production = $this->get_option('paypal_marketing_solutions_cid_production', '');
$this->show_on_minicart = $this->get_option('show_on_minicart', 'yes');
$this->show_on_minicart = $this->get_option('show_on_minicart', 'no');
$this->pending_authorization_order_status = $this->get_option('pending_authorization_order_status', 'On Hold');
$this->enable_in_context_checkout_flow = $this->get_option('enable_in_context_checkout_flow', 'yes');
if ($this->enable_notifyurl == 'yes') {
Expand Down Expand Up @@ -778,7 +778,8 @@ public function init_form_fields() {
'title' => __('Minicart', 'paypal-for-woocommerce'),
'label' => __('Show Express Checkout button in the WooCommerce Minicart.', 'paypal-for-woocommerce'),
'type' => 'checkbox',
'default' => 'yes'
'default' => 'no',
'description' => __('Enabling this option will cause the PayPal button JS to load on every page, which could negatively affect page load times on your site.'),
),
'button_position' => array(
'title' => __('Cart Button Position', 'paypal-for-woocommerce'),
Expand Down