Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dist_lim is set to 100 inside of calculate_channel_spatial_enrichment in spatial_analysis.py #678

Closed
cliu72 opened this issue Aug 26, 2022 · 0 comments · Fixed by #679
Closed

dist_lim is set to 100 inside of calculate_channel_spatial_enrichment in spatial_analysis.py #678

cliu72 opened this issue Aug 26, 2022 · 0 comments · Fixed by #679
Assignees
@ackagel
Labels
bug Something isn't working

Comments

@cliu72
Copy link
Contributor

cliu72 commented Aug 26, 2022

Describe the bug
dist_lim is a variable that can be passed into calculate_channel_spatial_enrichment. However, inside of that function, dist_lim is being set to 100 (and not the variable that the user specifies).

ark-analysis/ark/analysis/spatial_analysis.py

Line 189 in f67104f

dist_mat=dist_matrix, dist_lim=100, analysis_type="channel",

Expected behavior
Change 100 to dist_lim.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ackagel ackagel

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Passes distance limit argument through channel enrichment function angelolab/ark-analysis
2 participants
@cliu72 @ackagel