Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Passes distance limit argument through channel enrichment function #679

Merged
merged 5 commits into from
Sep 21, 2022
Merged

Passes distance limit argument through channel enrichment function #679

merged 5 commits into from
Sep 21, 2022

Conversation

ackagel
Copy link
Contributor

@ackagel ackagel commented Aug 26, 2022 •
edited
Loading

Closes #678

@ackagel ackagel requested a review from cliu72 August 26, 2022 18:32
cliu72
cliu72 approved these changes Aug 26, 2022
View reviewed changes
Copy link
Contributor

@cliu72 cliu72 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sweet

@ngreenwald
Copy link
Member

Bro, how is it possible that in this day and age you're still not correctly tagging issues to be closed in your PRs???

@cliu72 cliu72 merged commit da4de27 into main Sep 21, 2022
@cliu72 cliu72 deleted the dist-lim-correction branch September 21, 2022 21:06
@srivarra srivarra added the bug Something isn't working label Sep 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cliu72 cliu72 cliu72 approved these changes

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

dist_lim is set to 100 inside of calculate_channel_spatial_enrichment in spatial_analysis.py
4 participants
@ackagel @ngreenwald @cliu72 @srivarra