Add ranges for requirements.txt and requirements-test.txt #253
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alex-l-kong
changed the title
ackagel
reviewed
Oct 1, 2020
ngreenwald
requested changes
Oct 2, 2020
ngreenwald
requested changes
Oct 2, 2020
Good catch, we could remove a lot of the libraries in On a side note, can you configure the version of |
ngreenwald
approved these changes
Oct 4, 2020
alex-l-kong
added a commit
that referenced
this pull request
Jan 14, 2021
* Create ranges for requirements * Fix range error for numpy * Test new range for scikit-image * Revert range back to 0.16.2 * Update mibilib to 1.2.8 * Update mibilib to 1.3.0 * Add ranges to requirements-test.txt * Add new requirements testing * See if force installing the most updated version of six does the trick * Don't cache packages * Revert back to original settings * Delete packages no longer needed * Now that kiosk-client patch added, try removing six and see if it works * Update requirements.txt to use new kiosk-client version * No longer need attrs in requirements-test.txt
y2kbugger
pushed a commit
that referenced
this pull request
Jul 29, 2021
* Create ranges for requirements * Fix range error for numpy * Test new range for scikit-image * Revert range back to 0.16.2 * Update mibilib to 1.2.8 * Update mibilib to 1.3.0 * Add ranges to requirements-test.txt * Add new requirements testing * See if force installing the most updated version of six does the trick * Don't cache packages * Revert back to original settings * Delete packages no longer needed * Now that kiosk-client patch added, try removing six and see if it works * Update requirements.txt to use new kiosk-client version * No longer need attrs in requirements-test.txt
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of this PR?
Addresses and closes #247.
How did you implement your changes
We add ranges to the libraries in
requirements.txtandrequirements-test.txtto add more flexibility.Remaining issues
Some ranges are going to be weird because of, well, ongoing development on the libraries we're using. For example, pretty sure that
skimagewill break for our repo if we use the latest non-dev version (some functionality has shifted around). Could require a lot of testing.