-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ranges for requirements.txt and requirements-test.txt #253
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good. just a question about scikit-image and git repo packages (mibilib)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you also confirm that all of these are still needed?
Good catch, we could remove a lot of the libraries in On a side note, can you configure the version of |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same thing here, we'll see if the six
issue gets addressed by Will tomorrow, if not we can merge this
* Create ranges for requirements * Fix range error for numpy * Test new range for scikit-image * Revert range back to 0.16.2 * Update mibilib to 1.2.8 * Update mibilib to 1.3.0 * Add ranges to requirements-test.txt * Add new requirements testing * See if force installing the most updated version of six does the trick * Don't cache packages * Revert back to original settings * Delete packages no longer needed * Now that kiosk-client patch added, try removing six and see if it works * Update requirements.txt to use new kiosk-client version * No longer need attrs in requirements-test.txt
* Create ranges for requirements * Fix range error for numpy * Test new range for scikit-image * Revert range back to 0.16.2 * Update mibilib to 1.2.8 * Update mibilib to 1.3.0 * Add ranges to requirements-test.txt * Add new requirements testing * See if force installing the most updated version of six does the trick * Don't cache packages * Revert back to original settings * Delete packages no longer needed * Now that kiosk-client patch added, try removing six and see if it works * Update requirements.txt to use new kiosk-client version * No longer need attrs in requirements-test.txt
What is the purpose of this PR?
Addresses and closes #247.
How did you implement your changes
We add ranges to the libraries in
requirements.txt
andrequirements-test.txt
to add more flexibility.Remaining issues
Some ranges are going to be weird because of, well, ongoing development on the libraries we're using. For example, pretty sure that
skimage
will break for our repo if we use the latest non-dev version (some functionality has shifted around). Could require a lot of testing.