-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Generate k means clustering count/mean value matrices by cell type and marker #268
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! Some more error checking and documentation mostly
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, just a couple questions about naming/descriptions
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, lets see if Adam has any feedback before merging
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great! Once this is merged, I'll need to revise some lines for the global-settings pr, but it doesn't look like that'll be difficult.
…d marker (#268) * Add function stubs * Add matrix generating process for clustering * Add testing for generate_cluster_labels * ADd testing for generate_cluster_matrix_results * Add exception testing for coverage * Address code review comments * Update docstring * Variable and docstring fixes to make things more clear * Fix docstring for cluster matrix function
…d marker (#268) * Add function stubs * Add matrix generating process for clustering * Add testing for generate_cluster_labels * ADd testing for generate_cluster_matrix_results * Add exception testing for coverage * Address code review comments * Update docstring * Variable and docstring fixes to make things more clear * Fix docstring for cluster matrix function
What is the purpose of this PR?
Addresses and closes #255. Now that we have a method to determine the optimal
k
for k-means clustering of a neighborhood matrix, we add functionality to generate count and mean value matrices by cell type and marker respectively for each cluster. This finishes up point 3 of #139.How did you implement your changes
We add a function to generate the actual k-means clusters and another to generate the corresponding count/mean value matrices.