Address coverage issues #300
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ngreenwald
requested changes
Oct 28, 2020
ngreenwald
requested changes
Oct 28, 2020
Co-authored-by: Noah Greenwald <noahfgreenwald@gmail.com>
ngreenwald
approved these changes
Oct 28, 2020
alex-l-kong
added a commit
that referenced
this pull request
Jan 14, 2021
* First pass at improving coverage * Remove duplicate check * Add extra test for multitiff and specified channel loading in load_imgs_from_dir * Do not run coverage on test_utils.py (that's for testing functions only) * Update ark/utils/spatial_analysis_utils_test.py Co-authored-by: Noah Greenwald <noahfgreenwald@gmail.com> Co-authored-by: Noah Greenwald <noahfgreenwald@gmail.com>
y2kbugger
pushed a commit
that referenced
this pull request
Jul 29, 2021
* First pass at improving coverage * Remove duplicate check * Add extra test for multitiff and specified channel loading in load_imgs_from_dir * Do not run coverage on test_utils.py (that's for testing functions only) * Update ark/utils/spatial_analysis_utils_test.py Co-authored-by: Noah Greenwald <noahfgreenwald@gmail.com> Co-authored-by: Noah Greenwald <noahfgreenwald@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of this PR?
Addresses and closes #256. We have quite a few lines that run important validation checks prior to performing an operation. While it's not feasible to test all of these, we should certainly try to do so where we can.
How did you implement your changes
We improve our testing functions to cover more cases, mostly that we're throwing errors properly.
Remaining issues
Is there a need to address the coverage issues in
test_utils.py? I don't think so since these are mostly for test functions. We should tellcoverallsto disregard this file when computing coverage.Also, is it worth writing test functions for
plot_utils.py?