-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve jupyter launching (Jupyter Lab + enhanced alternate PORT) #438
Conversation
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
c2b65aa
to
b5a051a
Compare
@ngreenwald Figured we could merge this into master prior to finalizing the metacluster GUI. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall looks good! Is there a code cleanliness reason that having the script be executable is preferable to running bash scriptname? Or just a personal preference?
I'd say it follows "least astonishment" since it allows both start_docker.sh
|
I did just push a small change, to use the slightly more portable https://stackoverflow.com/questions/10376206/what-is-the-preferred-bash-shebang |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Got it, that all makes sense.
What is the purpose of this PR?
start_docker.sh
to pass the first available port to jupyter so that "remapped port" warning is no longer required.How did you implement your changes
I've touched start_docker.sh and Dockerfile.
For details, see commit history as I have broken up commits to tell story clearly.
Remaining issues
None