Allow generate_deepcell_input to accept other img_sub_folder values (including None) for non-MIBItiff inputs #471
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…n-MIBItiff files in generate_deepcell_input
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
ngreenwald
approved these changes
Oct 1, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of this PR?
Closes #470. A bug in
generate_deepcell_inputdefaulted theimg_sub_foldervalue passed intoload_imgs_for_treeto always be'TIFs'. We need it to accept theimg_sub_foldervalue passed intogenerate_deepcell_inputinstead.How did you implement your changes
In addition to changing this, we also change the default value for
img_sub_folderofgenerate_deepcell_inputto beNoneinstead of'TIFs'.