Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Patch MibiTracker download to prevent downloading of channels from Moly points #489

Merged
merged 2 commits into from
Dec 16, 2021

Conversation

alex-l-kong
Copy link
Contributor

What is the purpose of this PR?

Runs user specify to download for QC analysis may contain Moly points. example_qc_metric_eval.ipynb is currently not equipped to handle this, so we add functionality in to prevent the download of Moly points.

How did you implement your changes

A check is added in download_mibitracker_data to remove any FOVs from the download which do not contain the channels desired. Since all other images will contain the full set of channels, this will remove any Moly points from the mix.

@alex-l-kong alex-l-kong self-assigned this Dec 16, 2021
@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@ngreenwald ngreenwald merged commit c1056de into master Dec 16, 2021
@ngreenwald ngreenwald deleted the qc_metric_moly branch December 16, 2021 22:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants