-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added exact_match to list_folders #507
Conversation
…o sorted() in various assert statements.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a couple testing comments.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, liking the new test_list_folders
structure with separate sections for exact_match = False
and exact_match = True
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Syntax looks nice, see comments below
If you haven't already, please read through our contributing guidelines before opening your PR
What is the purpose of this PR?
This PR closes #360. It adds an
exact_match
function parameter to thelist_folders
function. In addition it adds specific tests forthe case where
exact_match
is set to True.How did you implement your changes
list_files
was used..sort()
withinassert
statements were replaced withsorted()
, as.sort()
returnsNone
.Remaining issues
There could be more instances of using asserts with
.sort()
instead of
sorted()
.For example:
Would not pass as
a.sort()
returnsNone
.However:
Would pass as
sorted()
returns the sorted iterable.