Run pytest as a separate job to avoid scripts from getting overwritten
#776
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ngreenwald
requested changes
Oct 18, 2022
| - stage: test_pypi_deploy | ||
| python: 3.8 |
There was a problem hiding this comment.
Any reason we don't need 3.8 anymore?
There was a problem hiding this comment.
@ngreenwald setting python: 3.8 at the beginning of .travis.yml already ensures Python 3.8 is used across all the jobs, so no need to specify it individually in each job.
ngreenwald
approved these changes
Oct 18, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of this PR?
Fixes a bug that can pop up when a separate
scriptsgets specified in ajob. This can overwrite the globalscript, which in effect skips thepytestruns in the PR.It's also better to separate
pytestout into its own job, as it shouldn't be included with the deployment stages. This can help us isolate thepytestlogs from the deployment logs.How did you implement your changes
Include a separate
pytest_runstage.