Add inverse method to ZScoreNorm to integrate with current matplotlib
#871
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…y num_boots to compute_topic_eda for gap_stat and gap_sds values
|
@ngreenwald can you please help merge this one in, a minor coveralls issue is preventing that from happening. |
ngreenwald
requested changes
Dec 20, 2022
ngreenwald
requested changes
Jan 20, 2023
|
@ngreenwald Let me make a new release for TMI which'll consist of changes from angelolab/alpineer#17. @alex-l-kong Try pinning tmi to |
|
@ngreenwald looks like it works now with |
ngreenwald
approved these changes
Jan 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of this PR?
Closes #810. Pinning
matplotlibto3.4.2is not a long-term solution for ensuring the colorbar scales properly.How did you implement your changes
From
matplotlib==3.5.0onwards, aninversemethod is explicitly required in a custommatplotlib.colors.Normalizerderived class for it to function properly. Additionally, we should fix the min and max at -3 and 3 respectively (and not using the min and max of the input data, as Zak was doing).To this end, we can also remove the
calibratemethod and rely on just__call__andinverse.Remaining issues
We will need to make a new Docker release for this.