-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add inverse
method to ZScoreNorm
to integrate with current matplotlib
#871
Conversation
…y num_boots to compute_topic_eda for gap_stat and gap_sds values
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good
@ngreenwald can you please help merge this one in, a minor coveralls issue is preventing that from happening. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This will require a new docker as well, lets wait to discuss
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ngreenwald Let me make a new release for TMI which'll consist of changes from angelolab/alpineer#17. @alex-l-kong Try pinning tmi to |
@ngreenwald looks like it works now with |
What is the purpose of this PR?
Closes #810. Pinning
matplotlib
to3.4.2
is not a long-term solution for ensuring the colorbar scales properly.How did you implement your changes
From
matplotlib==3.5.0
onwards, aninverse
method is explicitly required in a custommatplotlib.colors.Normalizer
derived class for it to function properly. Additionally, we should fix the min and max at -3 and 3 respectively (and not using the min and max of the input data, as Zak was doing).To this end, we can also remove the
calibrate
method and rely on just__call__
andinverse
.Remaining issues
We will need to make a new Docker release for this.