Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

type check Javascript Object Literals in function parameters #21

Merged
merged 4 commits into from
Sep 16, 2014

Conversation

MetaMemoryT
Copy link
Contributor

see new tests added.

@angelozerr
Copy link
Owner

Your patch seems very cool. Could you please create too a demo with your patch that you name Issue21.html. Thank's!

@MetaMemoryT
Copy link
Contributor Author

Sure, I am working on it right now.

@angelozerr
Copy link
Owner

Sure, I am working on it right now.

Cool, I'm waiting for your new PR.

Just one question, have you intention to create a tern-chrome-apps plugin like https://github.com/aki2o/tern-gas ?

@MetaMemoryT
Copy link
Contributor Author

Yes, I did plan to make a tern-chrome-apps plugin, I looked at the repository you referenced, it looks like I could reuse some code in it, if I were to go the html route, I thought about going the "parse the idl" route: like
https://github.com/dart-gde/chrome.dart

I wonder, which would be easier?

Thanks for the reference, I would try to build a metadata file also, like: https://github.com/angelozerr/tern.java/blob/master/core/tern.core/metadata/gas.metadata.json

I want to collaborate with anyone else working on this, so effort is not wasted.

@angelozerr
Copy link
Owner

I want to collaborate with anyone else working on this, so effort is not wasted.

I will be glad to host your future tern-chrome-apps inside tern.java.

Don't hesitat eto create PR for tern.java or tell me when you will hav efinished, I will integrate it in tern.java

Thanks for the reference, I would try to build a metadata file also, like: https://github.com/angelozerr/tern.java/blob/master/core/tern.core/metadata/gas.metadata.json

this metadata file is used by tern.java inside Eclipse

@angelozerr
Copy link
Owner

@MetaMemoryT could you add the Issue21.html in order to I accept your PR and I integrate your work on tern.java

Thank's

@MetaMemoryT
Copy link
Contributor Author

I added Issue21.html

angelozerr added a commit that referenced this pull request Sep 16, 2014
type check Javascript Object Literals in function parameters
@angelozerr angelozerr merged commit 1414fdd into angelozerr:master Sep 16, 2014
@angelozerr
Copy link
Owner

Thank's!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants