Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release 1.0 and next steps #306

Closed
paulvi opened this issue Aug 4, 2015 · 20 comments
Closed

Release 1.0 and next steps #306

paulvi opened this issue Aug 4, 2015 · 20 comments
Milestone

Comments

@paulvi
Copy link
Contributor

paulvi commented Aug 4, 2015

What and when?

@angelozerr
Copy link
Owner

What

https://github.com/angelozerr/tern.java/wiki/New-and-Noteworthy-1.0.0

When

I don't know, perhaps in September. I would like to try to provide Tern Explorer #289 (if I can)

@angelozerr angelozerr added this to the 1.0.0 milestone Aug 31, 2015
@angelozerr
Copy link
Owner

tern.java was released, thanks @pascalleclercq! Waiting for angular eclipse.

@paulvi
Copy link
Contributor Author

paulvi commented Sep 1, 2015

I saw this.

So is ES6 for 1.1 ?

@angelozerr
Copy link
Owner

So is ES6 for 1.1 ?

Yes! I have started to integrates tern-es6 #308 but there are a lot of bugs with other tern plugins. I'm fixing it.

So 1.1.0 will provide completion, hyperlink, hover, (and perhaps validation if I have time) for ES6 and ES6 modules. But as JSDT doesn't support ES6, they will have 2 problems :

  • syntax coloration 'I have developped a simple POC with a new JS editor to use acorn and https://github.com/katspaugh/tj-mode). I will commit soon my POC. It should be really cool if JSDT could delegate synatx coloration with an extension point.
  • JSDT validation problem. It should really cool if JSDT Validator could be disabled (teh only mean that I have found , is not to set JavaScript nature to the project.

The issue https://bugs.eclipse.org/bugs/show_bug.cgi?id=473559 speak about JSDT / ES6 but I had none answer for the moment.

paulvi pushed a commit to Nodeclipse/www.nodeclipse.org that referenced this issue Sep 1, 2015
@paulvi
Copy link
Contributor Author

paulvi commented Sep 1, 2015

Frankly wiki pages for New-and-Noteworthy-1.0.0 should use deeper levels.

I could hardly understand relations when doing announce Nodeclipse/www.nodeclipse.org@6e23d56

Note that level 1 and level 2 # and ## draws horizontal line. That groups sections. When everything is divided by horizontal line relationships are not clear.

@paulvi paulvi mentioned this issue Sep 1, 2015
@piotrtomiak
Copy link
Contributor

@angelozerr after doing the JS Debugger, I am back on Tern track :) I am happy to hear that ES 6 integration is coming in! Actually, all of the work you've done is amazing :) Have you considered contributing the extension for different syntax colorer to JSDT?

@angelozerr
Copy link
Owner

Frankly wiki pages for New-and-Noteworthy-1.0.0 should use deeper levels.

You mean above New-and-Noteworthy-1.1.0 in the sidebar?

Note that level 1 and level 2 # and ## draws horizontal line. That groups sections. When everything is divided by horizontal line relationships are not clear.

What you mean? It is about sidebar? content of New-and-Noteworthy?

I am back on Tern track :)

@piotrtomiak very cool! I hope those new features will help you.

I am happy to hear that ES 6 integration is coming in!

Yes I have integrated tern-es6. Now I must fix bugs in some tern plugins.

Actually, all of the work you've done is amazing :)

Thanks!

Have you considered contributing the extension for different syntax colorer to JSDT?

I have not developped this extension point. I hope JSDT will provide that. I have created a POC by implementing ITokenScanner with https://github.com/katspaugh/tj-mode Performance seems very goof even with big files. I have tested this implementation of ITokenScanner inside a custom textEditor that I have created (I don't use JSDT Editor -(). Hope JSDT will provide this extension point.

@piotrtomiak are you interested with my POC? I could commit it if you wish. Here a screenshot :

@piotrtomiak
Copy link
Contributor

@angelozerr there is no extension point for a different code scanner in JSDT, but they are being created in JavaScriptSourceViewerConfiguration (initializeScanners method). I think it should be possible to add an extension point to JSDT UI plugin, so that you can override default code scanners. For MyEclipse I will just patch that class, but it's not that easy if you need to depend on the official WTP build.

@piotrtomiak
Copy link
Contributor

@piotrtomiak are you interested with my POC? I could commit it if you wish. Here a screenshot :

I'll probably be, once I get to the point of integrating the newest version, but I will try to modify existing JSDT scanners. We don't want to change editor ID for our users.

@angelozerr
Copy link
Owner

created in JavaScriptSourceViewerConfiguration (initializeScanners method). I think it should be possible to add an extension point to JSDT UI plugin

Thanks for your info. I will study that.

We don't want to change editor ID for our users.

Me too. My idea is to set my implementation of scanner in a tern.eclipse and add in a sample teh use of this scanner. So you will able to to use my scanner without my custom editor (that I have created just to test my scanner)

@angelozerr
Copy link
Owner

@piotrtomiak for highlight issue, please comment at #310

@paulvi paulvi changed the title Release 1.0 Release 1.0 and next steps Sep 2, 2015
@paulvi
Copy link
Contributor Author

paulvi commented Sep 4, 2015

@paulvi
Copy link
Contributor Author

paulvi commented Sep 4, 2015

1.0 usually is grandiose relase, but wiki is not logically organized

Read contents below, how many times there is validation?

Include/Exclude Tern script paths

ECMAScript 6 (Promise)

Node (required module)

Hover

Validation

RequireJS (required module)

Completion

Hyperlink

Hover

Validation

Delite

Tern Hyperlink inside HTML

Browser Extension

  • for HTML elements ids :
  • for CSS Selectors :

jQuery Extension

YUI

Validation

Multiple type support

JSDoc support

  • here a sample with assignment type error :
  • here a sample with function parameter type error:

Validation Settings Changed

Tern Explorer

@angelozerr
Copy link
Owner

@paulvi I fill N&N as soon as I implement feature. If you think it's not very well organized, please change it. Thanks.

@paulvi
Copy link
Contributor Author

paulvi commented Sep 8, 2015

I was not able to understand, so not able to organize.

If it were more organized, I could have understood.

It is not bad, it just could have been closer to perfect for a 1.0 release

@angelozerr
Copy link
Owner

Frankly wiki pages for New-and-Noteworthy-1.0.0 should use deeper levels.

Sorry I had not seen this problem. I have fixed that https://github.com/angelozerr/tern.java/wiki/New-and-Noteworthy-1.0.0

@paulvi Is it ok for you?

@paulvi
Copy link
Contributor Author

paulvi commented Sep 13, 2015

Now it is even worse , without my changes as at #306 (comment)

e.g. what would https://github.com/angelozerr/tern.java/wiki/New-and-Noteworthy-1.0.0#hover-1 mean?

Skip for now, just remember for next time.

@angelozerr
Copy link
Owner

Now it is even worse

Is it better https://github.com/angelozerr/tern.java/wiki/New-and-Noteworthy-1.0.0 ?

@paulvi
Copy link
Contributor Author

paulvi commented Sep 14, 2015

I see the same old only level 1 and level 2 sections, with each drawing horizontal line.

@angelozerr
Copy link
Owner

I see the same old only level 1 and level 2 sections, with each drawing horizontal line.

An now?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants