Added translation for instruction LDRSW (literal). #12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
interpreted relativley to the current instruction pointer/program counter. See ARMv8-A Architecture Reference Manual (C6.6.95)
|
Have you submitted this to valgrind? Maintaining an actual fork of VEX is something we'd prefer to avoid, so if it's only present in |
|
No I didn't do it so far. I will give it a try to reach the valgrind maintainers. |
|
FYI: After some major testing with a few hundred mach-o binaries, the added instruction does not cause any problems so far. |
|
Oh, sorry I forgot about this. Yes, we don't really like maintaining a fork of valgrind, but like, that's kind of what we have to be doing right now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The operand is interpreted relatively to the current instruction pointer/program counter. See ARMv8-A Architecture Reference Manual (C6.6.95)