Add support for adding more clients #58
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit puts the client creation logic into a function. By running the script followed by `add_client`, the user will be asked a few questions and a new peer will be added. Removing client is **not** supported. The client files have random names. Fix for #3
|
randshell
reviewed
Jul 2, 2020
Comment on lines
+7
to
+14
| if [[ $SERVER_PUB_IP =~ .*:.* ]] | ||
| then | ||
| echo "IPv6 Detected" | ||
| ENDPOINT="[$SERVER_PUB_IP]:$SERVER_PORT" | ||
| else | ||
| echo "IPv4 Detected" | ||
| ENDPOINT="$SERVER_PUB_IP:$SERVER_PORT" | ||
| fi |
There was a problem hiding this comment.
@angristan why do we need parenthesis?
There was a problem hiding this comment.
Because that's how you regex match in a bash if...
There was a problem hiding this comment.
If anything changes how the variables are used to anchor them. For example ${SERVER_PUB_IP} etc
There was a problem hiding this comment.
I'm sorry @AndreiG6, I meant why we need [ ] for IPv6. Line 10
If it's for escaping the : char we can use ${SERVER_PUB_IP} instead of an if case.
There was a problem hiding this comment.
It's not escaping anything, just poor concat/formating I suppose. Somewhere there's probably a split for "ipv4/6:port" format. As in whatever uses that $ENDPOINT var
randshell
added a commit
to randshell/wireguard-install
that referenced
this pull request
Jul 2, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit puts the client creation logic into a function.
By running the script followed by
add_client, the user will be asked a few questions and a new peer will be added.Removing client is not supported.
The client files have random names.
Fix for #3