Refactor script #92
Merged
Refactor script #92
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We already have the variables we need in the lines above
Follow naming of openvpn-install repository
The sed command is easier to understand than multiple grep If IPv4 isn't available use IPv6
Fixes angristan#68 Co-authored-by: Chris Lewicki <chris@lewicki.dev>
Needs improvement
Code adapted from angristan/openvpn-install#550. Thanks @TheBritishAccent IPv6 regex tested with fd42:42:42::1 and fdc9:281f:04d7:9ee9::1
Needed for a later headless installation code
We changed arguments to a menu in d765194
angristan#95 (comment) Fedora might need this change too.
The server configuration has `$CLIENT_WG_IPV4/32,$CLIENT_WG_IPV6/128` and it is inconsistent with the client configuration `$CLIENT_WG_IPV4/24,$CLIENT_WG_IPV6/64`. We only want 1 IP for the peer, so the fix is changing clients subnets to /32 and /128.
Closed
Fix angristan#96 Ported from openvpn-install repo
wormi4ok
approved these changes
Jul 20, 2020
angristan
reviewed
Jul 24, 2020
Co-authored-by: Stanislas <angristan@pm.me>
angristan
reviewed
Jul 30, 2020
Remove OS condition. It also happen on Debian now, because we update the kernel from the backports, so we need to reboot
|
Great! Thank you very much for this |
angristan
approved these changes
Jul 31, 2020
randshell
added a commit
to randshell/wireguard-install
that referenced
this pull request
Sep 6, 2020
Previously it wouldn't work when the HOST BIT was more than 1 digit angristan#92 (comment)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I followed the style of the openvpn-install repository and used some of its code. Thanks to everyone that contributed there.
The other additions are:
$SERVER_WG_IPV4and$SERVER_WG_IPV6when suggesting the client IPparamsfile and apply it to all clients, removing support for customizing DNS for individual clients. If this is a problem we can add again the code to allow customization but maybe use the sourced DNS as a suggestion for clients that need a different one"${var}"stylefirewall-cmdonly iffirewalldis running. Fixes WARNING: WireGuard does not seem to be running. main process exited. FirewallD is not running #95$HOME. Fixes wrong permission after install #96Tested on Debian 10