Merge changes from teonsystems #8
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…me being, add license and disclamer, suggest original package.
…ins about it. As soon as original package updates this dependency to recent release (2.x+), this should be reverted.
Reason: If email content file is pulled directly from Maildir on Linux, it has body newlines separated by \n rather than \r\n which is what mail systems use internally (unverified claim!). This broke validation.
Merging original licensing info, as specified by original author: #5
|
Thanks - I'll work on this today. |
angrychimp
requested changes
Sep 19, 2018
There was a problem hiding this comment.
There are a lot of stylistic changes here that differ significantly from what I was originally intending. Let me take some more time to review these, but I might just take some of what you've done and adapt it to fit in more with what has been working.
Also, there are some breaking changes here that I'd like to avoid.
| * [openssl](http://us1.php.net/manual/en/openssl.installation.php) | ||
| * [phpseclib](http://phpseclib.sourceforge.net/) | ||
| ``` | ||
| composer require teon/dkim |
There was a problem hiding this comment.
namespace needs to be amended for the PR
| --------- | ||
| ```php | ||
| $msgContent = "..."; | ||
| $dkimValidator = new \Teon\DKIM\Validator($msgContent); |
|
|
||
| define('PHPSECLIB_USE_EXCEPTIONS', true); | ||
| namespace Teon\DKIM; |
| @@ -38,13 +31,13 @@ | |||
| * | |||
| * @param string $rawMessage | |||
| * @return DKIM | |||
| * @throws DKIM_Exception | |||
| * @throws Exception | |||
There was a problem hiding this comment.
I'd really prefer to avoid throwing generic exceptions, since the code could be wrapped in libraries with multiple exceptions, and an precise exception type is very useful
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is somewhat messy, but you'll need to deal with the fairly large differences in this fork anyway. See #7