Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Problem with version 1.1.3 #32

Closed
marwin1991 opened this issue Jan 11, 2023 · 2 comments · Fixed by #33
Closed

Problem with version 1.1.3 #32

marwin1991 opened this issue Jan 11, 2023 · 2 comments · Fixed by #33
Assignees
Labels
bug Something isn't working

Comments

@marwin1991
Copy link
Collaborator

$ ss2ju sast gl-sast-report.json gl-sast-report.xml .gitlab/ss2ju-config.yml
Traceback (most recent call last):
  File "/usr/local/bin/ss2ju", line 8, in <module>
    sys.exit(main())
             ^^^^^^
  File "/usr/local/lib/python3.11/site-packages/secscanner2junit/__init__.py", line 50, in main
    ss2ju_config = get_config()
                   ^^^^^^^^^^^^
TypeError: get_config() missing 1 required positional argument: 'path'
Uploading artifacts for failed job

@angrymeir

@marwin1991 marwin1991 added the bug Something isn't working label Jan 11, 2023
@angrymeir angrymeir self-assigned this Jan 11, 2023
@marwin1991
Copy link
Collaborator Author

We call get_config() without argument:

    if args.config:
        ss2ju_config = get_config()

should be changed to

    if args.config:
        ss2ju_config = get_config(args.config)

@angrymeir ?

angrymeir added a commit that referenced this issue Jan 11, 2023
@angrymeir
Copy link
Owner

Yes, ah that's what I was talking about with the testing blind spots...Guess I'll create CI stage, that builds the package and executes tests on the entire software in addition to Unit-tests

@angrymeir angrymeir mentioned this issue Jan 11, 2023
@angrymeir angrymeir linked a pull request Jan 11, 2023 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants