fix: update dependency @angular/compiler to v16.2.3 (#1458)

angular-eslint · Sep 3, 2023 · 2b895a8 · 2b895a8
1 parent d9a9f62
commit 2b895a8
Show file tree

Hide file tree

Showing 7 changed files with 25 additions and 19 deletions.
diff --git a/jest.preset.js b/jest.preset.js
@@ -13,4 +13,9 @@ module.exports = {
    * More info: https://jestjs.io/docs/upgrading-to-jest29#snapshot-format
    */
   snapshotFormat: { escapeString: true, printBasicPrototype: true },
+  /**
+   * Jest does not support Prettier v3 for inline snapshots so we need this workaround:
+   * https://github.com/jestjs/jest/issues/14305
+   */
+  prettierPath: require.resolve('prettier-v2-for-jest-inline-snapshots'),
 };
diff --git a/package.json b/package.json
@@ -28,8 +28,8 @@
     "check-clean-integration-test-fixtures": "tools/scripts/check-clean-integration-test-fixtures.sh",
     "pre-commit": "yarn lint-staged && yarn check-clean-integration-test-fixtures",
     "pre-push": "yarn format-check",
-    "format": "prettier --write \"./**/*.{ts,js,json,md}\"",
-    "format-check": "prettier --check \"./**/*.{ts,js,json,md}\"",
+    "format": "node_modules/prettier/bin/prettier.cjs --write \"./**/*.{ts,js,json,md}\"",
+    "format-check": "node_modules/prettier/bin/prettier.cjs --check \"./**/*.{ts,js,json,md}\"",
     "lint": "eslint . --ext .js,.ts",
     "typecheck": "nx run-many -t typecheck",
     "exec-tool": "ts-node --transpile-only --project tsconfig.tools.json tools/scripts/exec-tool.ts",
@@ -52,7 +52,7 @@
     "@actions/core": "1.10.0",
     "@actions/github": "5.1.1",
     "@angular/cli": "16.2.1",
-    "@angular/compiler": "16.1.4",
+    "@angular/compiler": "16.2.3",
     "@commitlint/cli": "17.7.1",
     "@commitlint/config-conventional": "17.7.0",
     "@nx/devkit": "16.5.1",
@@ -93,6 +93,7 @@
     "nx": "16.5.1",
     "nx-cloud": "16.3.0",
     "prettier": "3.0.2",
+    "prettier-v2-for-jest-inline-snapshots": "npm:prettier@^2",
     "rimraf": "5.0.1",
     "rollup": "^3.21.0",
     "strip-ansi": "6.0.1",

diff --git a/packages/eslint-plugin-template/src/rules/conditional-complexity.ts b/packages/eslint-plugin-template/src/rules/conditional-complexity.ts
@@ -79,7 +79,7 @@ export default createESLintRule<Options, MessageIds>({
           data: { maxComplexity, totalComplexity },
         });
       },
-      Interpolation({ expressions }: Interpolation) {
+      Interpolation$1({ expressions }: Interpolation) {
         for (const expression of expressions) {
           const totalComplexity = getTotalComplexity(expression);
 

diff --git a/packages/eslint-plugin-template/src/rules/no-interpolation-in-attributes.ts b/packages/eslint-plugin-template/src/rules/no-interpolation-in-attributes.ts
@@ -25,7 +25,7 @@ export default createESLintRule<Options, typeof MESSAGE_ID>({
     const sourceCode = context.getSourceCode();
 
     return {
-      ['BoundAttribute Interpolation'](interpolation: Interpolation) {
+      ['BoundAttribute Interpolation$1'](interpolation: Interpolation) {
         const {
           sourceSpan: { start, end },
         } = interpolation;

diff --git a/packages/template-parser/src/index.ts b/packages/template-parser/src/index.ts
@@ -43,7 +43,7 @@ const KEYS: VisitorKeys = {
   BoundText: ['value'],
   Conditional: ['condition', 'trueExp', 'falseExp'],
   Element$1: ['children', 'inputs', 'outputs', 'attributes'],
-  Interpolation: ['expressions'],
+  Interpolation$1: ['expressions'],
   PrefixNot: ['expression'],
   Program: ['templateNodes'],
   PropertyRead: ['receiver'],

diff --git a/packages/template-parser/tests/index.test.ts b/packages/template-parser/tests/index.test.ts
@@ -18,7 +18,7 @@ describe('parseForESLint()', () => {
           Object {
             "loc": Object {
               "end": Object {
-                "column": 10,
+                "column": 39,
                 "line": 2,
               },
               "start": Object {
@@ -28,15 +28,15 @@ describe('parseForESLint()', () => {
             },
             "range": Array [
               7,
-              11,
+              40,
             ],
             "type": "Block",
             "value": "eslint-disable-next-line",
           },
           Object {
             "loc": Object {
               "end": Object {
-                "column": 10,
+                "column": 33,
                 "line": 4,
               },
               "start": Object {
@@ -46,7 +46,7 @@ describe('parseForESLint()', () => {
             },
             "range": Array [
               74,
-              78,
+              101,
             ],
             "type": "Block",
             "value": "some other comment",

diff --git a/yarn.lock b/yarn.lock
@@ -95,10 +95,10 @@
     symbol-observable "4.0.0"
     yargs "17.7.2"
 
-"@angular/compiler@16.1.4":
-  version "16.1.4"
-  resolved "https://registry.yarnpkg.com/@angular/compiler/-/compiler-16.1.4.tgz#6b42ce34c0388bc1d88a3f37b55504a3428e22c8"
-  integrity sha512-5iKx8g+6/LtiRhbqMS2Jw1AshFUb4M8LO9WQKfRoE+5mZrDOYkAQYgOlAO7fk0mOCXeZcHJBbq2nuwDfwsZIiw==
+"@angular/compiler@16.2.3":
+  version "16.2.3"
+  resolved "https://registry.yarnpkg.com/@angular/compiler/-/compiler-16.2.3.tgz#f7bb3838d1424dfdb1c320babac855289fa8a9dc"
+  integrity sha512-bFc7YRHNdBJZD2HiORBQun2p40emvEt8D4JwXnW1JIStAWKJOXLyEjx045wNddqH7NpUq8AE2F1i82hIDNQZ1g==
   dependencies:
     tslib "^2.3.0"
 
@@ -8783,16 +8783,16 @@ prettier-bytes@^1.0.4:
   resolved "https://registry.yarnpkg.com/prettier-bytes/-/prettier-bytes-1.0.4.tgz#994b02aa46f699c50b6257b5faaa7fe2557e62d6"
   integrity sha512-dLbWOa4xBn+qeWeIF60qRoB6Pk2jX5P3DIVgOQyMyvBpu931Q+8dXz8X0snJiFkQdohDDLnZQECjzsAj75hgZQ==
 
+"prettier-v2-for-jest-inline-snapshots@npm:prettier@^2", prettier@^2.6.2:
+  version "2.8.8"
+  resolved "https://registry.yarnpkg.com/prettier/-/prettier-2.8.8.tgz#e8c5d7e98a4305ffe3de2e1fc4aca1a71c28b1da"
+  integrity sha512-tdN8qQGvNjw4CHbY+XXk0JgCXn9QiF21a55rBe5LJAU+kDyC4WQn4+awm2Xfk2lQMk5fKup9XgzTZtGkjBdP9Q==
+
 prettier@3.0.2:
   version "3.0.2"
   resolved "https://registry.yarnpkg.com/prettier/-/prettier-3.0.2.tgz#78fcecd6d870551aa5547437cdae39d4701dca5b"
   integrity sha512-o2YR9qtniXvwEZlOKbveKfDQVyqxbEIWn48Z8m3ZJjBjcCmUy3xZGIv+7AkaeuaTr6yPXJjwv07ZWlsWbEy1rQ==
 
-prettier@^2.6.2:
-  version "2.8.8"
-  resolved "https://registry.yarnpkg.com/prettier/-/prettier-2.8.8.tgz#e8c5d7e98a4305ffe3de2e1fc4aca1a71c28b1da"
-  integrity sha512-tdN8qQGvNjw4CHbY+XXk0JgCXn9QiF21a55rBe5LJAU+kDyC4WQn4+awm2Xfk2lQMk5fKup9XgzTZtGkjBdP9Q==
-
 pretty-format@^29.0.0, pretty-format@^29.5.0:
   version "29.5.0"
   resolved "https://registry.yarnpkg.com/pretty-format/-/pretty-format-29.5.0.tgz#283134e74f70e2e3e7229336de0e4fce94ccde5a"