Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(schematics): options for convert-tslint-to-eslint #419

Merged
merged 12 commits into from Apr 18, 2021

Conversation

JamesHenry
Copy link
Member

Resolve #395, resolves #307, resolves #380

@JamesHenry JamesHenry added this to the v4 milestone Apr 18, 2021
@JamesHenry JamesHenry added package: schematics Angular CLI schematics which are responsible for configuration generation and automated migrations BREAKING CHANGE This is a breaking change and should only be released as part of a new major version labels Apr 18, 2021
@nx-cloud
Copy link

nx-cloud bot commented Apr 18, 2021

Nx Cloud Report

CI ran the following commands for commit 87b7076. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch

Status Command
#000000 nx run-many --target=build --all --parallel
#000000 nx run-many --target=check-configs --all --parallel
#000000 nx run-many --target=test --all --parallel
#000000 nx run-many --target=typecheck --all --parallel

Sent with 💌 from NxCloud.

@codecov
Copy link

codecov bot commented Apr 18, 2021

Codecov Report

Merging #419 (5e6bc5b) into master (26ded89) will decrease coverage by 3.75%.
The diff coverage is 39.18%.

@@            Coverage Diff             @@
##           master     #419      +/-   ##
==========================================
- Coverage   69.15%   65.40%   -3.76%     
==========================================
  Files          13       14       +1     
  Lines         509      581      +72     
  Branches       92      110      +18     
==========================================
+ Hits          352      380      +28     
- Misses        119      153      +34     
- Partials       38       48      +10     
Impacted Files Coverage Δ
...s/schematics/src/convert-tslint-to-eslint/utils.ts 60.65% <11.11%> (-20.74%) ⬇️
...s/schematics/src/convert-tslint-to-eslint/index.ts 46.19% <18.51%> (-4.75%) ⬇️
packages/schematics/src/utils.ts 73.04% <57.14%> (-2.21%) ⬇️
...matics/src/migrations/update-4-0-0/update-4-0-0.ts 93.33% <93.33%> (ø)

@JamesHenry JamesHenry merged commit 18fd863 into master Apr 18, 2021
@JamesHenry JamesHenry deleted the next-major-release/v4 branch April 18, 2021 13:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
BREAKING CHANGE This is a breaking change and should only be released as part of a new major version package: schematics Angular CLI schematics which are responsible for configuration generation and automated migrations
Projects
None yet
1 participant