Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wrong engines in package.json #2696

Closed
daton89 opened this issue Mar 15, 2018 · 5 comments
Closed

wrong engines in package.json #2696

daton89 opened this issue Mar 15, 2018 · 5 comments

Comments

@daton89
Copy link

daton89 commented Mar 15, 2018

wrong engines in package.json

  "engines": {
    "node": "^6.2.2",
    "npm": "^3.9.5"
  },

so during install i got:

yarn install v1.3.2
warning package.json: "dependencies" has dependency "babel-core" with range "^6.18.2" that collides with a dependency in "devDependencies" of the same name with version "^6.6.5"
warning package.json: "dependencies" has dependency "babel-preset-es2015" with range "^6.18.0" that collides with a dependency in "devDependencies" of the same name with version "^6.6.0"
info No lockfile found.
warning angular-fullstack-generator@0.0.0: "dependencies" has dependency "babel-core" with range "^6.18.2" that collides with a dependency in "devDependencies" of the same name with version "^6.6.5"
warning angular-fullstack-generator@0.0.0: "dependencies" has dependency "babel-preset-es2015" with range "^6.18.0" that collides with a dependency in "devDependencies" of the same name with version "^6.6.0"
[1/5] 🔍  Validating package.json...
error angular-fullstack-generator@0.0.0: The engine "node" is incompatible with this module. Expected version "^6.2.2".
error Found incompatible module
info Visit https://yarnpkg.com/en/docs/cli/install for documentation about this command.
Item Version
generator-angular-fullstack 5.0.0-rc.0
Node 8.9.4
npm 5.6.0
Operating System OS X 10.11.2
@albert-92
Copy link
Contributor

albert-92 commented Mar 15, 2018

I'm not sure if the supported Node.js version is still 6. If that is the case, everything works as supposed.

You can either downgrade your Node to >= 6.2.2 && < 7.0.0 or use yarn install --ignore-engines after the initial installation fails and see if it works without any compatibility issues.

Could you give feedback if you run into the problem #2694 afterwards?

@Awk34
Copy link
Member

Awk34 commented Mar 15, 2018

We should change it to be >= the latest acceptable 6.x.x version, probably. I wouldn't be against making the minimum node version in the 8.x.x range either, since it's LTS now.

@albert-92
Copy link
Contributor

@Awk34 That sounds reasonable. I'll test it with the latest LTS release 8.10.0 and report if i find any compatibility issues.

@daton89
Copy link
Author

daton89 commented Mar 16, 2018

@albert-92 in the project the gulpfile.babel.js was not found after run the generator.. i guess that for install the 5.0.0-rc-0 you need to use node >= 8 so there is no reason to downgrade Node

@albert-92
Copy link
Contributor

@daton89 upgrade to 5.0.0-rc-1, the gulpfile.babel.js problem is fixed there and then run yarn install --ignore-engines if you want to use node 8.

It looks like generator-angular-fullstack works with either node 6 or node 8 just fine.

albert-92 pushed a commit to albert-92/generator-angular-fullstack that referenced this issue Mar 22, 2018
Changed required node version to >= 6.x.x for now, so that the installation is not limited to node 6.
Also npm >= 3.9.5, since current version is 5.7.1

Closes angular-fullstack#2696
Awk34 added a commit that referenced this issue Mar 24, 2018
fix(app): wrong engines in package.json #2696
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants