-
Notifications
You must be signed in to change notification settings - Fork 31
Adding Prettier Formatter #10
Comments
If you not only add it, but also format everything: please do so! 😉 |
I also set prettier in ngx-deploy-npm Is very useful and I love it |
@kauppfbi Thanks for the PR! This is my first time using prettier and I like it. 😄👍 Since
will only look at files from the top level. But we also have the
So my silly Can you help me out? 😇 |
Related side note: We should also enable "formatOnSave" for VSCode so that prettier runs whenever you hit save in the editor. Super useful in the workflow because you never need to think about how to format code again. |
Hi @JohannesHoppe, sure, I can help you with that. Then I will prepare a PR with
fine for you? |
Sounds awesome! 👍 |
* work in progress * docs: keeping track of all the forks * chore: migrate from `configuration` to `buildTarget` - only unit tests are evaluated right now - no real tests were done yet * ci: bump node version to see if this fixes the break cause it works on my machine (tm) * Revert "ci: bump node version to see if this fixes the break" This reverts commit b300026. * tweaking dependencies / peerDependencies as seen in angularfire: https://github.com/angular/angularfire/blob/2ce41aa0af8c5f42df65f5ac5b2b5a50fb6f4300/package.json#L41-L68 commander has some breaking changes, so let's risk nothing here and rollback * fixing build and tests, cleanup see angular-schule/ngx-deploy-starter#10 * minor: docs + removes astronaut emoij ... since 👨🚀 emoij is combined (🧑🚀) and breaks on some cmds * docs: breaking change, 1.0.0-rc.1 * docs: suggestion from @fmalcher * Apply suggestions from code review many thanks to @fmalcher Co-authored-by: Ferdinand Malcher <ferdinand@malcher.media> Co-authored-by: Ferdinand Malcher <ferdinand@malcher.media>
Hi,
When I forked the project, adding Prettier was one of my first steps.
As it is very popular and provides standard formatting for every contribution, I suggest to use Prettier.
If you like me to do so, I would prepare a PR with Prettier configured. I could also add pretty-quick and husky to enforce formatting in a pre-commit hook.
Let me know how you think about it 👂
The text was updated successfully, but these errors were encountered: