Doc: Guide mistakes

[DWand]

I'm working on Guide translation into Russian language. It's based on fb09e39 commit now.
During translation I see some mistakes in the text. But I don't want to touch an English version of the Guide for this moment.
To prevent those mistakes to be forgotten I'd like to put them here. So they could be fixed in future )

[DWand]

01_conceptual-overview.ngdoc
line 18
use the $tranlsate service.

[DWand]

07_multi-language.ngdoc
line 16
to add different translation tables add a time!

line 22
to add more translation tables add a time.

line 28
as argument through $translations(), you

[sgara]

I'm on it!
I already started working on this (and corrected those)
I'll PR soon

[DWand]

Ok, it's cool. I'll write here new found mistakes for this version. It's hard to me to jump through different commits. Will synchronize translation with new Guide version after )

[0x-r4bbit]

You guys rock!

[sgara]

A'right. Please notify me here when you're done reviewing the english version so that I can take your corrections into account before PRing ;)

[DWand]

;-)

[DWand]

07_multi-language.ngdoc
line 82-83
let you tell angular-translate do so.
which language to use

I'd like to prefer the second variant about language

[DWand]

07_multi-language.ngdoc
line 97
asynchronous laoders

[DWand]

Ha!
There is a same typo all along the guide (or just till 07 chapter).
In examples, translation for PARAGRAPH id in English.
There is "Srsly", instead of "Seriously".

[0x-r4bbit]

Haha, srsly is just a short version of seriously. Its not really a typo.

On Fri, Aug 9, 2013 at 11:33 AM, Max Prichinenko
notifications@github.comwrote:

Ha!
There is a same typo all along the guide (or just till 07 chapter).
In examples, translation for PARAGRAPH id in English.
There is "Srsly", instead of "Seriously".

—
Reply to this email directly or view it on GitHubhttps://github.com//issues/128#issuecomment-22384483
.

/pp

[DWand]

@PascalPrecht, Ok then )
That is one of reasons why I don't want to touch the English version ))

[DWand]

08_storages.ngdoc
line 27
To you one of those storages,

[DWand]

09_custom-storages.ngdoc
line 8
remember the last choosed

line 57
to save the last choosed language.

[DWand]

09_custom-storages.ngdoc
line 22 (also not sure)
with a get() and a set() method.

Isn't "methodS" is actually needed here?

[DWand]

09_custom-storages.ngdoc
line 39
Provide a custom storage as a separate
(Is it actually provide or providing?)

[DWand]

09_custom-storages.ngdoc
line 55-56
angular-translate will use $injector to get an instance of the given factory name

Actually, why do we need an instance of the name? (O,o)
Maybe it's also would be better to use shorter sentences to avoid such strange situations and provide proper punctuation?

[DWand]

09_custom-storages.ngdoc
line 130
custom service doesn't do anything

Maybe, it's better to say "does nothing"?
Anyway, this sentence about custom service is written in a cool form! I like it )))

[DWand]

10_asynchronous-loading.ngdoc
line 16
with support for two different asynchronous loader.

[DWand]

10_asynchronous-loading.ngdoc
line 28
Once its installed, make sure you've embeded it in your HTML document. Allright,

[DWand]

10_asynchronous-loading.ngdoc
line 69
a lang paramter, you

[DWand]

10_asynchronous-loading.ngdoc
line 79
You can simply use the staticFilesLoader with this pattern like this:

this ... this

[DWand]

10_asynchronous-loading.ngdoc
line 96
translation data asynchonously as

[DWand]

10_asynchronous-loading.ngdoc
line 104
Lazy loading at is best!

[DWand]

10_asynchronous-loading.ngdoc
line 112
since we'return executing stuff asynchronously.

I'm not sure is it typo or something like a short form of a phrase

[0x-r4bbit]

It's a typo coming from my abbreviation configuration of Vim. re => return
Have to fix that one

On Sun, Aug 11, 2013 at 11:20 AM, Max Prichinenko
notifications@github.comwrote:

10_asynchronous-loading.ngdoc
line 112
since we'return executing stuff asynchronously.

I'm not sure is it typo or something like a short form of a phrase

—
Reply to this email directly or view it on GitHubhttps://github.com//issues/128#issuecomment-22454901
.

/pp

[DWand]

11_custom-loaders.ngdoc
line 5
Customer Loaders

[DWand]

11_custom-loaders.ngdoc
line 71
the propery when

[DWand]

12_pluralization.ngdoc
line 32
how can we use MessageFormat with angular-translate to use

use ... use
Maybe, this sentence could be rephrased somehow? For example, how can we use ... to get ...

[DWand]

12_pluralization.ngdoc
line 98
Do you see any differents?

[DWand]

13_custom-interpolators.ngdoc
line 74
Allright. So what did we here. setLocale() simpley store the value of the current

[DWand]

13_custom-interpolators.ngdoc
line 76
Remember how to

[DWand]

13_custom-interpolators.ngdoc
line 85
Just like there's a method for Storages (useStorage()) and Loaders (useLoader()),

Maybe, plurals are needed here

[DWand]

13_custom-interpolators.ngdoc
line 94
You app now uses your custom

[DWand]

14_error-handling.ngdoc
line 11
Using log handler extension for missing translations

There is no really a mistake here. But it sounds like an ext for missing translations, and not an ext for handling them. But, I'm not an English-speaker, so I could be wrong.

[DWand]

14_error-handling.ngdoc
line 12

[DWand]

16_migration-guide.ngdoc
line 10
angular-translate-interpolation-default is required.

[DWand]

I don't translate a "Migration Guide" chapter to this moment, because I don't know is it really needed. Actually, at this point a translation is mostly ready. But it requires some fine tuning before PR. So, since I'll not look into English version of the Guide we could consider that there are all mistakes I found in the text.

[DWand]

@sgara, my revision of the Guide is done )

[sgara]

Thanks pal! Great job.
I'll finish all that as soon as I got time. Last 2weeks were crazy :)
We can close this issue I think.

Stephane

On Aug 11, 2013, at 17:58, Max Prichinenko notifications@github.com wrote:

@sgara, my revision on the Guide is done )

�
Reply to this email directly or view it on GitHub.

[DWand]

Yeah, I'll close it ) Like that this info is not lost )

[jsteenkamp]

Typo in docs here: http://pascalprecht.github.io/angular-translate/#/guide/02_getting-started

Under section "Teaching your app a language" the function() is in the wrong place in both code examples showing app.config.

app.config(function ['$translateProvider', ($translateProvider) {

}]);

should be

app.config(['$translateProvider', function($translateProvider) {

}]);

[0x-r4bbit]

I re-open this until the fixes landed in master @sgara any progress? :)

[sgara]

Still working on it.
I'm in holidays too so it goes slower than expected ;)

Stephane

On Aug 19, 2013, at 15:22, Pascal Precht notifications@github.com wrote:

I re-open this until the fixes landed in master @sgara any progress? :)

�
Reply to this email directly or view it on GitHub.

[0x-r4bbit]

@sgara Ah okay then. Please don't forget to update your canary branch, since it has some breaking changes for the doc generation.

[0x-r4bbit]

@sgara We're almost ready for a major release! :D hurry up!

[sgara]

Yeaaaaah! Just back from holidays. It should be should ready for tonight

[0x-r4bbit]

@sgara Awesome! Looking foward to it! make sure to pull latest changes and use the generate_site.sh script to generate the site (obviously).

[0x-r4bbit]

Okay, I'm ready for deployment.