Skip to content
This repository has been archived by the owner on Jan 29, 2024. It is now read-only.

Strip comments from .min.js #1461

Closed
PaulAnnekov opened this issue Apr 13, 2016 · 2 comments
Closed

Strip comments from .min.js #1461

PaulAnnekov opened this issue Apr 13, 2016 · 2 comments
Assignees
@knalli
Labels
bug
Milestone
2.11.1

Comments

@PaulAnnekov
Copy link

Subject of the issue

It looks like at least latest version includes all jsdoc comments in minified version https://cdn.jsdelivr.net/angular.translate/2.11.0/angular-translate.min.js.

Expected behaviour

Doc comments must be stripped from minified version.
@knalli knalli added this to the 2.12.0 milestone Apr 13, 2016
@knalli knalli added the bug label Apr 13, 2016
@knalli knalli self-assigned this Apr 13, 2016
@knalli
Copy link
Member

knalli commented Apr 13, 2016

Thanks. We should revisit the uglify options. Probably introduced with 66877f0

@knalli knalli modified the milestones: 2.11.1, 2.12.0 Apr 24, 2016
marclr added a commit to marclr/angular-translate that referenced this issue Apr 28, 2016
@marclr
fix(grunt): Work around uglify to preserveComments as expected
a5facd6 
Fixes angular-translate#1461
Root cause: gruntjs/grunt-contrib-uglify#366
@marclr marclr mentioned this issue Apr 28, 2016
Closed
knalli pushed a commit that referenced this issue Apr 29, 2016
@marclr @knalli
fix(grunt): add work-around for uglify preserveComments as expected
32cdedb 
Root cause: gruntjs/grunt-contrib-uglify#366

Fixes #1461
@knalli
Copy link
Member

knalli commented Apr 29, 2016

I just picked a workaround by @marclr -- Thank you. Will be released soon in 2.11.1.

@knalli knalli closed this as completed Apr 29, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@knalli knalli

Labels
bug
Projects
None yet
Milestone
2.11.1
Development

No branches or pull requests
2 participants
@knalli @PaulAnnekov