Sanitation strategy sce fails with fallback language #1618

MarijnMensinga · 2016-10-17T14:39:20Z

Sanitation strategy `sce` fails with fallback language

When using a fallback language in conjuction with the sanitation strategy sce a type error is thrown when the string to translate is only available in the fallback language file.

Demo: https://plnkr.co/edit/iWdsq62cnGAY3mdN3aTM?p=preview

The fallbackTranslationInstant function expects a string as result but it gets a TrustedValueHolderType object.

typeError: result.substr is not a function
    at getFallbackTranslationInstant (angular-translate.js:1791)
    at resolveForFallbackLanguageInstant (angular-translate.js:1893)
    at fallbackTranslationInstant (angular-translate.js:1924)
    at determineTranslationInstant (angular-translate.js:2019)
    at Function.$translate.instant (angular-translate.js:2551)
    at translateFilter (angular-translate.js:3620)
    at fn (eval at compile (angular.js:14817), <anonymous>:4:97)
    at oneTimeInterceptedExpression (angular.js:16046)
    at oneTimeWatch (angular.js:15984)
    at Scope.$digest (angular.js:17515)

Your environment

version of angular-translate: 2.12.1
version of angular: 1.5.8
which browser and its version: Chrome 53.0.2785.143 m

Steps to reproduce

Two languages
Set one langauge as fallback for another
Set sanitation strategy to sce
Translate a string via a filter

Demo: https://plnkr.co/edit/iWdsq62cnGAY3mdN3aTM?p=preview

Expected behaviour

Everything should be nicely translated

Actual behaviour

TypeError: TrustedValueHolderType object instead of expected string

The text was updated successfully, but these errors were encountered:

knalli · 2016-10-17T14:45:28Z

Hm, did you have missed saving something in the demo? I guess, at least there is one missing file (angular-sanitize).

MarijnMensinga · 2016-10-17T14:53:22Z

Sorry the translation had to be done via filters in order to get the error, I updated the plnkr:
https://plnkr.co/edit/iWdsq62cnGAY3mdN3aTM?p=preview

knalli · 2016-10-18T07:32:10Z

Ok, demo working!

Well, looks like sce does not working together with the linking feature (string based).

MarijnMensinga · 2016-10-25T09:01:46Z

@knalli are you planning on creating a fix for this? If so, when will it be released you think?

knalli · 2016-10-25T09:26:28Z

@MarijnMensinga It will take some days. If you can make a PR fixing the issue, it will faster.

MarijnMensinga · 2016-10-25T10:27:46Z

I've created a PR #1630
This fixes my problems.. I'm not 100% sure this is enough for a permanent fix in the entire library?

…ectly Although we have to reconsider the result type of this, this will fix sce+linking. Fixes #1618 Replaces #1630

knalli · 2016-10-30T19:32:29Z

Fix: 1ede55e

MarijnMensinga changed the title ~~Sanitisation strategy sce fails with fallback language~~ Sanitation strategy sce fails with fallback language Oct 17, 2016

knalli added this to the 2.12.2 milestone Oct 25, 2016

knalli added the bug label Oct 25, 2016

MarijnMensinga mentioned this issue Oct 25, 2016

fix(service) sce sanitation with fallback language #1630

Closed

4 tasks

knalli added a commit that referenced this issue Oct 30, 2016

fix(service): fix .instant() not handling TrustedValueHolderType corr…

1ede55e

…ectly Although we have to reconsider the result type of this, this will fix sce+linking. Fixes #1618 Replaces #1630

knalli closed this as completed Oct 30, 2016

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Sanitation strategy sce fails with fallback language #1618

Sanitation strategy sce fails with fallback language #1618

MarijnMensinga commented Oct 17, 2016 •

edited

Loading

knalli commented Oct 17, 2016

MarijnMensinga commented Oct 17, 2016

knalli commented Oct 18, 2016

MarijnMensinga commented Oct 25, 2016

knalli commented Oct 25, 2016

MarijnMensinga commented Oct 25, 2016

knalli commented Oct 30, 2016 •

edited

Loading

Sanitation strategy sce fails with fallback language #1618

Sanitation strategy sce fails with fallback language #1618

Comments

MarijnMensinga commented Oct 17, 2016 • edited Loading