Skip to content
This repository has been archived by the owner on Jan 29, 2024. It is now read-only.

Incorrect value of 'params' in static loader request #1646

Closed
zgmnkv opened this issue Nov 11, 2016 · 3 comments
Closed

Incorrect value of 'params' in static loader request #1646

zgmnkv opened this issue Nov 11, 2016 · 3 comments
Labels
Milestone

Comments

@zgmnkv
Copy link
Contributor

zgmnkv commented Nov 11, 2016

According to angular docs 'params' should be a map, not string
https://docs.angularjs.org/api/ng/service/$http#usage

@tspaeth
Copy link
Member

tspaeth commented Nov 11, 2016

Thanks for the report. You're right. But gladly, until now it didn't cause any issues so far 😄

@tspaeth tspaeth added the bug label Nov 11, 2016
@zgmnkv
Copy link
Contributor Author

zgmnkv commented Nov 11, 2016

In my case I added an http interceptor and expected params to be always an object.

@knalli
Copy link
Member

knalli commented Nov 11, 2016

Yes, we should fix this. Do you want to provide a patch? Either we replace it with {} or remove it completely. Cannot say here what is better, should have a look into it.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

3 participants