Skip to content
This repository has been archived by the owner on Jan 29, 2024. It is now read-only.

Re-structure demo folder #49

Closed
0x-r4bbit opened this issue May 14, 2013 · 14 comments
Closed

Re-structure demo folder #49

0x-r4bbit opened this issue May 14, 2013 · 14 comments
Assignees
Labels
Milestone

Comments

@0x-r4bbit
Copy link
Member

Clean demos for different examples.

@ghost ghost assigned 0x-r4bbit May 14, 2013
@DWand
Copy link
Member

DWand commented May 14, 2013

And what if there are no access to the Enternet, for example?

2013/5/14 Pascal Precht notifications@github.com

There are plunks. That's enough.


Reply to this email directly or view it on GitHubhttps://github.com//issues/49
.

@0x-r4bbit
Copy link
Member Author

The code is documented well enough. If we really wanna provide a demo folder, then we should at least re-structure it by example.

@knalli
Copy link
Member

knalli commented May 14, 2013

Actually, IMHO, it is sometimes more comfortable to dev/test/try out something against existing demo or samples.

And, separated demo at Plunkr has one drawback: They are not version aware. It is sometimes really hard to find out how a piece of software should work in a non-latest version. You won't support Plunkers to all version, will you? :)

Yeah, we have tests. But nobody want read them to find out how the plugin works. At least, they aren't reality aware. They are the technically reference tests.

@0x-r4bbit
Copy link
Member Author

I'm okay with that. So, demos have to be re-structured.

@0x-r4bbit
Copy link
Member Author

I've updated the issue title.

@DWand
Copy link
Member

DWand commented May 14, 2013

Are there any proposals about the correct structure?

@0x-r4bbit
Copy link
Member Author

Nope. I would simply go like

demo
| - example1
| - example2

etc.

@knalli
Copy link
Member

knalli commented May 14, 2013

I'd say: Each demo case should have its own environment (they will share all common js sources) with a specific name about what it will demonstrate.

@DWand
Copy link
Member

DWand commented May 14, 2013

As a variant 3703627

@knalli
Copy link
Member

knalli commented May 14, 2013

Yeah 👍 :) More structured than before, with additional comments. Looks very good.

I'd not use white spaces in urls.. sometimes has issues. Replace it with _.

@DWand
Copy link
Member

DWand commented May 14, 2013

Ok, I'll try to fix it tomorrow.

@0x-r4bbit
Copy link
Member Author

@DWand thanks a lot man! Like @knalli said, the file names shouldn't contain whitespaces. Replace the whitespaces with underscores, and I'll merge this soonish into canary :)

@DWand
Copy link
Member

DWand commented May 15, 2013

Here it is #51.
Spaces are replaced with underscores in file names.
And, actually, I don't know German. So, I replaced it to Russian in demos. Hope you will not be offended by this.

@0x-r4bbit
Copy link
Member Author

MERGED

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

3 participants