feat(loaders): add jsonp support

[juanpujol]

I needed jsonp support so I did this small patch. Very easy to use. Just pass method: 'JSONP' as an option on $translateUrlLoader.

$translateUrlLoader({
  key: 'de_DE',
  url: 'foo/bar.json?callback=JSON_CALLBACK',
  method: 'JSONP'
 });

$translateProvider.useLoader('$translatePartialLoader', {
  urlTemplate: 'https://your-site/translation/{part}?locale={lang}&callback=JSON_CALLBACK',
  method: 'JSONP'
});

Works on loader-partial and loader-url.

Cheers.

[knalli]

@juanpujol Yes, that's looking great!

@PascalPrecht Should we not change the api to something like this?

   return function (options) {

      if (!options || !options.url) {
        throw new Error('Couldn\'t use urlLoader since no url is given!');
      }

      var deferred = $q.defer();

      $http(angular.extend({
        url: options.url,
        params: { lang: options.key },
        method: 'GET'
      }, options.options || {})).success(function (data) {
        deferred.resolve(data);
      }).error(function (data) {

[0x-r4bbit]

@knalli yes! Do you wanna do it?

[mateusleon]

Hello there! This pull request will be made? I was searching for a solution and this pull request will made it! Can you please merge this patch? Thanks a lot.

[knalli]

As of b685601 (and a small fixup 8613bef), you should be able to do this with any loader you want. Perhaps do you want to check out?

[juanpujol]

Sorry, is not clear how to use that $http on the loader. I want to load my parts via jsonp. I tried this:

$translatePartialLoaderProvider.addPart('3');
$translateProvider.useLoader('$translatePartialLoader', {
  urlTemplate: translateUrl + '/api/translation/{part}?locale{lang}&callback=JSON_CALLBACK',
  $http: {    
    method: 'JSONP'
  }
});

But I still get the No 'Access-Control-Allow-Origin', so is not working.

Can somebody help me please?

Thank you.

[knalli]

Well, that's actually all you need. Do you use the latest 2.4? 'Access-Control-Allow-Origin' does mean nothing*, the question is only if the requested was made via JSONP.

• Appendix: I mean, it is irrelevant for this issue. If the request is made as JSONP, the options were put to AJS correctly. Then it is up to the server. Generally, the requests look like url&jsonp=callback

[juanpujol]

Is not working. Before I had a forked version of the partial, forcing the method attribute. (https://github.com/juanpujol/bower-angular-translate-loader-partial/blob/master/angular-translate-loader-partial.js#L20) This worked fine, but I want to use the new v2.4 solution now.

[knalli]

Can you track this down on your own? It looks like I have accidentally swapped argument 2 and 3 here

angular-translate/src/service/loader-partial.js

Lines 49 to 52 in 6d35c6b

	$http(angular.extend({}, $httpOptions, {
	method : 'GET',
	url: this.parseUrl(urlTemplate, lang)
	})).success(function(data){

[juanpujol]

Yes, just swapped back the arguments and it worked like a charm =)

$http(angular.extend({}, {
  method: 'GET',
  url: this.parseUrl(urlTemplate, lang)
}, $httpOptions))

Thank You.