Skip to content
This repository has been archived by the owner on Jan 29, 2024. It is now read-only.

Order of $http options wrong #754

Closed
knalli opened this issue Sep 30, 2014 · 8 comments
Closed

Order of $http options wrong #754

knalli opened this issue Sep 30, 2014 · 8 comments
Assignees
Milestone

Comments

@knalli
Copy link
Member

knalli commented Sep 30, 2014

Perhaps 2.4.1

$http(angular.extend({}, $httpOptions, {
method : 'GET',
url: this.parseUrl(urlTemplate, lang)
})).success(function(data){

      $http(angular.extend({}, $httpOptions, {
        method : 'GET',
        url: this.parseUrl(urlTemplate, lang)
      }))

-->

      $http(angular.extend({}, {
        method : 'GET',
        url: this.parseUrl(urlTemplate, lang)
      }, $httpOptions))

Relates #547

@knalli knalli self-assigned this Sep 30, 2014
@knalli
Copy link
Member Author

knalli commented Sep 30, 2014

We have to check all loaders.

@knalli knalli added the bug label Sep 30, 2014
@tspaeth
Copy link
Member

tspaeth commented Sep 30, 2014

👍

2 similar comments
@juanpujol
Copy link

👍

@riconegri
Copy link

+1

knalli added a commit that referenced this issue Sep 30, 2014
This adds also some tests for the loader options (here: $http.method)

Fixes #754
Fixes #547
@knalli knalli added this to the 2.4.1 milestone Sep 30, 2014
@knalli
Copy link
Member Author

knalli commented Sep 30, 2014

Ok, if there is nothing wrong the patch will land. See attached.

@knalli knalli added the bug-fix label Sep 30, 2014
@juanpujol
Copy link

Thank you @knalli

@riconegri
Copy link

Great...

knalli added a commit to knalli/angular-translate that referenced this issue Oct 3, 2014
This adds also some tests for the loader options (here: $http.method)

Fixes angular-translate#754
Fixes angular-translate#547
@knalli knalli closed this as completed Oct 3, 2014
@knalli
Copy link
Member Author

knalli commented Oct 3, 2014

in 2.4.1 released

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

4 participants