Skip to content
This repository has been archived by the owner on Jan 29, 2024. It is now read-only.

use default interpolator instead of return original translationId #730

Closed
wants to merge 1 commit into from

Conversation

tsaikd
Copy link
Contributor

@tsaikd tsaikd commented Sep 18, 2014

if not define translationId

before:
$filter("translate")("Name: {{name}}", {name: "User"}) // "Name: {{name}}"

after:
$filter("translate")("Name: {{name}}", {name: "User"}) // "Name: User"

Add test case for @knalli asking.
I'm not sure how to refer the #716 , so I send a new pull request.

@knalli
Copy link
Member

knalli commented Sep 18, 2014

Thank you, landed as 3efaac5 -- I have changed the commit message according our guide lines.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants