Skip to content
This repository has been archived by the owner on Jan 29, 2024. It is now read-only.

use default interpolator instead of return original translationId #716

Closed
wants to merge 0 commits into from

Conversation

tsaikd
Copy link
Contributor

@tsaikd tsaikd commented Sep 10, 2014

if not define translationId

before:
$filter("translate")("Name: {{name}}", {name: "User"}) // "Name: {{name}}"

after:
$filter("translate")("Name: {{name}}", {name: "User"}) // "Name: User"

@knalli
Copy link
Member

knalli commented Sep 18, 2014

Yes, I this looks like a feature :)

  1. Please follow contribution guide lines: create a branch based on the latest canary, apply your changes and make a PR against canary
  2. please add a test ensure this will work

@knalli
Copy link
Member

knalli commented Sep 18, 2014

replaced by #730

@knalli knalli closed this Sep 18, 2014
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants